[incubator-seatunnel] branch dev updated: [Improve][Connector-v2] Remove unused options for jdbc source factory (#3794)

[gaojun2048]

This is an automated email from the ASF dual-hosted git repository.

gaojun2048 pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 861004d30 [Improve][Connector-v2] Remove unused options for jdbc 
source factory (#3794)
861004d30 is described below

commit 861004d309cb99023cfd1f1ea49a8adbb96d4949
Author: hailin0 <wanghai...@apache.org>
AuthorDate: Mon Dec 26 12:10:31 2022 +0800

    [Improve][Connector-v2] Remove unused options for jdbc source factory 
(#3794)
---
 docs/en/connector-v2/sink/Jdbc.md                  |  5 ++++
 .../seatunnel/jdbc/source/JdbcSourceFactory.java   | 28 ++++++++++++----------
 2 files changed, 21 insertions(+), 12 deletions(-)

diff --git a/docs/en/connector-v2/sink/Jdbc.md 
b/docs/en/connector-v2/sink/Jdbc.md
index 2ece74b0d..9f2aa2e75 100644
--- a/docs/en/connector-v2/sink/Jdbc.md
+++ b/docs/en/connector-v2/sink/Jdbc.md
@@ -45,6 +45,7 @@ support `Xa transactions`. You can set `is_exactly_once=true` 
to enable it.
 | xa_data_source_class_name                 | String  | No       | -           
  |
 | max_commit_attempts                       | Int     | No       | 3           
  |
 | transaction_timeout_sec                   | Int     | No       | -1          
  |
+| auto_commit                               | Boolean | No       | true        
  |
 | common-options                            |         | no       | -           
  |
 
 ### driver [string]
@@ -119,6 +120,10 @@ The number of retries for transaction commit failures
 The timeout after the transaction is opened, the default is -1 (never 
timeout). Note that setting the timeout may affect
 exactly-once semantics
 
+### auto_commit [boolean]
+
+Automatic transaction commit is enabled by default
+
 ### common options
 
 Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details
diff --git 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java
 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java
index fe904e536..02513b6ff 100644
--- 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java
+++ 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java
@@ -17,24 +17,17 @@
 
 package org.apache.seatunnel.connectors.seatunnel.jdbc.source;
 
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.AUTO_COMMIT;
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.BATCH_INTERVAL_MS;
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.BATCH_SIZE;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.CONNECTION_CHECK_TIMEOUT_SEC;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.DRIVER;
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.IS_EXACTLY_ONCE;
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.MAX_COMMIT_ATTEMPTS;
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.MAX_RETRIES;
+import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.FETCH_SIZE;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.PARTITION_COLUMN;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.PARTITION_LOWER_BOUND;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.PARTITION_NUM;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.PARTITION_UPPER_BOUND;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.PASSWORD;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.QUERY;
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.TRANSACTION_TIMEOUT_SEC;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.URL;
 import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.USER;
-import static 
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.XA_DATA_SOURCE_CLASS_NAME;
 
 import org.apache.seatunnel.api.configuration.util.OptionRule;
 import org.apache.seatunnel.api.table.factory.Factory;
@@ -51,9 +44,20 @@ public class JdbcSourceFactory implements TableSourceFactory 
{
 
     @Override
     public OptionRule optionRule() {
-        return OptionRule.builder().required(URL, DRIVER, 
QUERY).optional(USER, PASSWORD, MAX_RETRIES, CONNECTION_CHECK_TIMEOUT_SEC, 
BATCH_SIZE,
-                BATCH_INTERVAL_MS, IS_EXACTLY_ONCE, XA_DATA_SOURCE_CLASS_NAME, 
MAX_COMMIT_ATTEMPTS, TRANSACTION_TIMEOUT_SEC, AUTO_COMMIT,
-                PARTITION_COLUMN, PARTITION_UPPER_BOUND, 
PARTITION_LOWER_BOUND, PARTITION_NUM)
-                .build();
+        return OptionRule.builder()
+            .required(
+                URL,
+                DRIVER,
+                QUERY)
+            .optional(
+                USER,
+                PASSWORD,
+                CONNECTION_CHECK_TIMEOUT_SEC,
+                FETCH_SIZE,
+                PARTITION_COLUMN,
+                PARTITION_UPPER_BOUND,
+                PARTITION_LOWER_BOUND,
+                PARTITION_NUM)
+            .build();
     }
 }