[GitHub] [incubator-seatunnel] lightzhao commented on a diff in pull request #3831: [Bug][KafkaSource]Fix the default value of commit_on_checkpoint.

[GitBox]

lightzhao commented on code in PR #3831:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3831#discussion_r1059219006


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/ConsumerMetadata.java:
##########
@@ -38,7 +38,7 @@ public class ConsumerMetadata implements Serializable {
     private String bootstrapServers;
     private Properties properties;
     private String consumerGroup;
-    private boolean commitOnCheckpoint = false;
+    private boolean commitOnCheckpoint = true;

Review Comment:
   The default value is from the parameter 'commit_on_checkpoint', but if the 
user does not set it, the default value of CommitOnCheckpoint of 
ConsumerMetadata will be taken, and its default value is false.
   <img width="898" alt="image" 
src="https://user-images.githubusercontent.com/40714172/210028726-f90d1f6c-df73-41be-873d-be3cfedf6007.png";>
   <img width="1054" alt="image" 
src="https://user-images.githubusercontent.com/40714172/210028752-6076e428-648a-42a6-ba3f-d9587f497cec.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org