TaoZex commented on code in PR #3840:
URL:
https://github.com/apache/incubator-seatunnel/pull/3840#discussion_r1059715266
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/AbstractReadStrategy.java:
##########
@@ -89,6 +94,28 @@ public Configuration getConfiguration(HadoopConf hadoopConf)
{
configuration.set(CommonConfigurationKeys.FS_DEFAULT_NAME_KEY,
hadoopConf.getHdfsNameKey());
configuration.set(String.format("fs.%s.impl", hadoopConf.getSchema()),
hadoopConf.getFsHdfsImpl());
hadoopConf.setExtraOptionsForConfiguration(configuration);
+ String principal = hadoopConf.getKerberosPrincipal();
+ String keytabPath = hadoopConf.getKerberosKeytabPath();
+ if (!isKerberosAuthorization && StringUtils.isNotBlank(principal)) {
+ // kerberos authentication and only once
+ if (StringUtils.isBlank(keytabPath)) {
+ throw new
FileConnectorException(CommonErrorCode.KERBEROS_AUTHORIZED_FAILED,
+ "Kerberos keytab path is blank, please check this
parameter that in your config file");
+ }
+ configuration.set("hadoop.security.authentication", "kerberos");
+ UserGroupInformation.setConfiguration(configuration);
+ try {
+ log.info("Start Kerberos authentication using principal {} and
keytab {}", principal, keytabPath);
+
UserGroupInformation.loginUserFromKeytab(hadoopConf.getKerberosPrincipal(),
+ hadoopConf.getKerberosKeytabPath());
+ log.info("Kerberos authentication successful");
+ } catch (IOException e) {
+ String errorMsg = String.format("Kerberos authentication
failed using this " +
+ "principal [%s] and keytab path [%s]", principal,
keytabPath);
+ throw new
FileConnectorException(CommonErrorCode.KERBEROS_AUTHORIZED_FAILED, errorMsg, e);
+ }
+ isKerberosAuthorization = true;
+ }
Review Comment:
How about encapsulating this duplicated code for reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
