hailin0 commented on code in PR #2832: URL: https://github.com/apache/incubator-seatunnel/pull/2832#discussion_r1060246529
########## seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml: ########## @@ -18,8 +18,8 @@ --> <project xmlns="http://maven.apache.org/POM/4.0.0"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; Review Comment: revert this file change ########## seatunnel-connectors-v2-dist/pom.xml: ########## @@ -0,0 +1,198 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: remove this module ########## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SqlType.java: ########## @@ -37,5 +37,5 @@ public enum SqlType { DATE, TIME, TIMESTAMP, - ROW; + ROW Review Comment: revert this file change ########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-clickhouse-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/ClickhouseIT.java: ########## @@ -74,6 +75,7 @@ import scala.Tuple2; +@Disabled("Temporary fast fix, reason1: Transactions are not supported. reason2: Invalid boolean value, should be true or false controlled by setting bool_true_representation and bool_false_representation") Review Comment: revert this file change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
