liugddx commented on code in PR #3906:
URL:
https://github.com/apache/incubator-seatunnel/pull/3906#discussion_r1065440501
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/ParquetWriteStrategy.java:
##########
@@ -299,4 +299,8 @@ private Schema buildAvroSchemaWithRowType(SeaTunnelRowType
seaTunnelRowType, Lis
MessageType seaTunnelRow =
Types.buildMessage().addFields(types.toArray(new
Type[0])).named("SeaTunnelRecord");
return schemaConverter.convert(seaTunnelRow);
}
+
+ @Override
+ public void close() {
+ }
Review Comment:
There's no operation here?
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/OrcWriteStrategy.java:
##########
@@ -359,4 +359,8 @@ private void setDoubleVector(Object value,
DoubleColumnVector doubleVector, int
throw new FileConnectorException(CommonErrorCode.ILLEGAL_ARGUMENT,
errorMsg);
}
}
+
+ @Override
+ public void close() {
+ }
Review Comment:
There's no operation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
