Hisoka-X commented on code in PR #3946:
URL:
https://github.com/apache/incubator-seatunnel/pull/3946#discussion_r1070805902
##########
seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/args/ClientCommandArgs.java:
##########
@@ -65,6 +69,10 @@ public class ClientCommandArgs extends AbstractCommandArgs {
description = "list job status")
private boolean listJob = false;
+ @Parameter(names = {"-cj", "--close-job"},
+ description = "Close client the task will also be closed")
+ private boolean closeJob = false;
Review Comment:
Just my opinon, I think user use shut down command to cancel job is
intuitive operation. If they want to continue running task after client closed,
they can use `-cj`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
