Hisoka-X commented on code in PR #3847:
URL:
https://github.com/apache/incubator-seatunnel/pull/3847#discussion_r1071038070
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java:
##########
@@ -49,6 +49,8 @@ public class ServerConfigOptions {
public static final Option<Integer> CHECKPOINT_STORAGE_MAX_RETAINED =
Options.key("max-retained").intType().defaultValue(1).withDescription("The
maximum number of retained checkpoints.");
+ public static final Option<String> QUEUE_TYPE =
Options.key("queue_type").stringType().defaultValue("disruptor").withDescription("The
internal data cache queue type.");
Review Comment:
The value should be enum, also please use `blockingQueue` at default value.
Then change doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
