[incubator-seatunnel] branch dev updated: [Bug][Connector-V2][Jdbc] Fixed no exception throwing problem (#3957)

[wanghailin]

This is an automated email from the ASF dual-hosted git repository.

wanghailin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 6ab266e59  [Bug][Connector-V2][Jdbc] Fixed no exception throwing 
problem (#3957)
6ab266e59 is described below

commit 6ab266e59412612bf947d8e6130c3c25b8d799cd
Author: Guangdong Liu <804167...@qq.com>
AuthorDate: Mon Jan 16 20:03:35 2023 +0800

     [Bug][Connector-V2][Jdbc] Fixed no exception throwing problem (#3957)
---
 .../connectors/seatunnel/jdbc/internal/JdbcOutputFormat.java          | 2 --
 .../jdbc/internal/executor/BufferedBatchStatementExecutor.java        | 4 +---
 .../connectors/seatunnel/jdbc/sink/JdbcSinkAggregatedCommitter.java   | 4 ++--
 .../seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkCommitter.java   | 4 ++--
 4 files changed, 5 insertions(+), 9 deletions(-)

diff --git 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcOutputFormat.java
 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcOutputFormat.java
index 2a84e13a7..0ee542811 100644
--- 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcOutputFormat.java
+++ 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcOutputFormat.java
@@ -244,6 +244,4 @@ public class JdbcOutputFormat<I, E extends 
JdbcBatchStatementExecutor<I>>
     public interface StatementExecutorFactory<T extends 
JdbcBatchStatementExecutor<?>>
         extends Supplier<T>, Serializable {
     }
-
-    ;
 }
diff --git 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/BufferedBatchStatementExecutor.java
 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/BufferedBatchStatementExecutor.java
index 3d35db613..7d514bf74 100644
--- 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/BufferedBatchStatementExecutor.java
+++ 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/BufferedBatchStatementExecutor.java
@@ -63,8 +63,6 @@ public class BufferedBatchStatementExecutor implements 
JdbcBatchStatementExecuto
         if (!buffer.isEmpty()) {
             executeBatch();
         }
-        if (statementExecutor != null) {
-            statementExecutor.closeStatements();
-        }
+        statementExecutor.closeStatements();
     }
 }
diff --git 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkAggregatedCommitter.java
 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkAggregatedCommitter.java
index 9b9ad9802..cba92db73 100644
--- 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkAggregatedCommitter.java
+++ 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkAggregatedCommitter.java
@@ -54,7 +54,7 @@ public class JdbcSinkAggregatedCommitter
             try {
                 xaFacade.open();
             } catch (Exception e) {
-                new 
JdbcConnectorException(CommonErrorCode.WRITER_OPERATION_FAILED, "unable to open 
JDBC sink aggregated committer", e);
+                throw new 
JdbcConnectorException(CommonErrorCode.WRITER_OPERATION_FAILED, "unable to open 
JDBC sink aggregated committer", e);
             }
         }
     }
@@ -89,7 +89,7 @@ public class JdbcSinkAggregatedCommitter
                 xaFacade.close();
             }
         } catch (Exception e) {
-            new 
JdbcConnectorException(CommonErrorCode.WRITER_OPERATION_FAILED, "unable to 
close JDBC sink aggregated committer", e);
+            throw new 
JdbcConnectorException(CommonErrorCode.WRITER_OPERATION_FAILED, "unable to 
close JDBC sink aggregated committer", e);
         }
     }
 }
diff --git 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkCommitter.java
 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkCommitter.java
index 48c9179f7..3a6b402d8 100644
--- 
a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkCommitter.java
+++ 
b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkCommitter.java
@@ -49,7 +49,7 @@ public class JdbcSinkCommitter
         try {
             xaFacade.open();
         } catch (Exception e) {
-            new 
JdbcConnectorException(CommonErrorCode.WRITER_OPERATION_FAILED, "unable to open 
JDBC sink committer", e);
+            throw new 
JdbcConnectorException(CommonErrorCode.WRITER_OPERATION_FAILED, "unable to open 
JDBC sink committer", e);
         }
     }
 
@@ -65,7 +65,7 @@ public class JdbcSinkCommitter
         try {
             xaGroupOps.rollback(commitInfos);
         } catch (Exception e) {
-            new 
JdbcConnectorException(JdbcConnectorErrorCode.XA_OPERATION_FAILED, "rollback 
failed", e);
+            throw new 
JdbcConnectorException(JdbcConnectorErrorCode.XA_OPERATION_FAILED, "rollback 
failed", e);
         }
     }
 }