zy-kkk commented on code in PR #3958: URL: https://github.com/apache/incubator-seatunnel/pull/3958#discussion_r1071856656
########## seatunnel-connectors-v2/connector-selectdb-cloud/src/main/java/org/apache/seatunnel/connector/selectdb/sink/committer/SelectDBCommitter.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.connector.selectdb.sink.committer; + +import static org.apache.seatunnel.connector.selectdb.sink.writer.LoadStatus.FAIL; +import static org.apache.seatunnel.connector.selectdb.sink.writer.LoadStatus.SUCCESS; + +import org.apache.seatunnel.api.sink.SinkCommitter; +import org.apache.seatunnel.connector.selectdb.config.SelectDBConfig; +import org.apache.seatunnel.connector.selectdb.exception.SelectDBConnectorErrorCode; +import org.apache.seatunnel.connector.selectdb.exception.SelectDBConnectorException; +import org.apache.seatunnel.connector.selectdb.rest.BaseResponse; +import org.apache.seatunnel.connector.selectdb.rest.CopyIntoResp; +import org.apache.seatunnel.connector.selectdb.util.HttpPostBuilder; +import org.apache.seatunnel.connector.selectdb.util.HttpUtil; +import org.apache.seatunnel.connector.selectdb.util.ResponseUtil; + +import org.apache.seatunnel.shade.com.typesafe.config.Config; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.ObjectMapper; +import lombok.extern.slf4j.Slf4j; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.entity.StringEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.util.EntityUtils; + +import java.io.IOException; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +@Slf4j +public class SelectDBCommitter implements SinkCommitter<SelectDBCommitInfo> { + private static final String COMMIT_PATTERN = "http://%s/copy/query";; + private static final int HTTP_TEMPORARY_REDIRECT = 200; + private final ObjectMapper objectMapper = new ObjectMapper(); + private final CloseableHttpClient httpClient; + private final SelectDBConfig selectdbConfig; + int maxRetry; + + public SelectDBCommitter(Config pluginConfig) { + this(SelectDBConfig.loadConfig(pluginConfig), SelectDBConfig.loadConfig(pluginConfig).getMaxRetries(), new HttpUtil().getHttpClient()); + } + + public SelectDBCommitter(SelectDBConfig selectdbConfig, int maxRetry, CloseableHttpClient client) { + this.selectdbConfig = selectdbConfig; + this.maxRetry = maxRetry; + this.httpClient = client; + } + + @Override + public List<SelectDBCommitInfo> commit(List<SelectDBCommitInfo> commitInfos) throws IOException { + for (SelectDBCommitInfo committable : commitInfos) { + commitTransaction(committable); + } + return Collections.emptyList(); + } + + @Override + public void abort(List<SelectDBCommitInfo> commitInfos) throws IOException { + } + + private void commitTransaction(SelectDBCommitInfo committable) throws IOException { + long start = System.currentTimeMillis(); + String hostPort = committable.getHostPort(); + String clusterName = committable.getClusterName(); + String copySQL = committable.getCopySQL(); + log.info("commit to cluster {} with copy sql: {}", clusterName, copySQL); + + int statusCode = -1; + String reasonPhrase = null; + int retry = 0; + Map<String, String> params = new HashMap<>(); + params.put("cluster", clusterName); + params.put("sql", copySQL); + boolean success = false; + CloseableHttpResponse response; + String loadResult = ""; + while (retry++ <= maxRetry) { + HttpPostBuilder postBuilder = new HttpPostBuilder(); + postBuilder.setUrl(String.format(COMMIT_PATTERN, hostPort)) + .baseAuth(selectdbConfig.getUsername(), selectdbConfig.getPassword()) + .setEntity(new StringEntity(objectMapper.writeValueAsString(params))); + try { + response = httpClient.execute(postBuilder.build()); + } catch (IOException e) { + log.error("commit error : ", e); + continue; + } + statusCode = response.getStatusLine().getStatusCode(); + reasonPhrase = response.getStatusLine().getReasonPhrase(); + if (statusCode != HTTP_TEMPORARY_REDIRECT) { + log.warn("commit failed with status {} {}, reason {}", statusCode, hostPort, reasonPhrase); + } else if (response.getEntity() != null) { + loadResult = EntityUtils.toString(response.getEntity()); + success = handleCommitResponse(loadResult); + if (success) { + log.info("commit success cost {}ms, response is {}", System.currentTimeMillis() - start, loadResult); + break; + } else { + log.warn("commit failed, retry again"); + } + } + } + + if (!success) { + log.error("commit error with status {}, reason {}, response {}", statusCode, reasonPhrase, loadResult); + throw new SelectDBConnectorException(SelectDBConnectorErrorCode.COMMIT_FAILED, committable.getCopySQL()); Review Comment: I think more information should be displayed in the log here, and exceptions should be thrown more concisely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
