EricJoy2048 commented on code in PR #4000:
URL:
https://github.com/apache/incubator-seatunnel/pull/4000#discussion_r1091480527
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java:
##########
@@ -163,10 +163,10 @@ private PartitionParameter initPartitionParameter(String
columnName, Connection
if (rs.next()) {
max = jdbcSourceOptions.getPartitionUpperBound().isPresent() ?
jdbcSourceOptions.getPartitionUpperBound().get() :
- Long.parseLong(rs.getString(1));
+ rs.getString(1) == null ? 0L :
Long.parseLong(rs.getString(1));
Review Comment:
I suggest use `Long.MAX_VALUE` and `Long.MIN_VALUE` when `rs.getString(1) ==
null` or `rs.getString(2) == null `. And then we should add warning log too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
