531651225 commented on code in PR #3679:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3679#discussion_r1091762315


##########
docs/en/connector-v2/source/StarRocks.md:
##########
@@ -0,0 +1,146 @@
+# StarRocks
+
+> StarRocks source connector
+
+## Description
+Read external data source data through StarRocks.
+The internal implementation of StarRocks source connector is obtains the query 
plan from the frontend (FE), 
+delivers the query plan as a parameter to BE nodes, and then obtains data 
results from BE nodes..
+## Key features
+
+- [x] [batch](../../concept/connector-v2-features.md)
+- [ ] [stream](../../concept/connector-v2-features.md)
+- [x] [exactly-once](../../concept/connector-v2-features.md)
+- [x] [schema projection](../../concept/connector-v2-features.md)
+
+## Options
+
+| name                    | type   | required | default value     |
+|-------------------------|--------|----------|-------------------|
+| node_urls               | list   | yes      | -                 |
+| username                | string | yes      | -                 |
+| password                | string | yes      | -                 |
+| database                | string | yes      | -                 |
+| table                   | string | yes      | -                 |
+| scan_filter             | string | no       | -                 |
+| fields                  | config | yes      | -                 |

Review Comment:
   already fix it.



##########
seatunnel-connectors-v2/connector-starrocks/pom.xml:
##########
@@ -54,5 +61,57 @@
             <artifactId>httpcore</artifactId>
             <version>${httpcore.version}</version>
         </dependency>
+        <dependency>
+            <groupId>com.starrocks</groupId>
+            <artifactId>starrocks-thrift-sdk</artifactId>
+            <version>${starrocks.thrift.sdk.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.arrow</groupId>
+            <artifactId>arrow-vector</artifactId>
+            <version>${arrow.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.arrow</groupId>
+            <artifactId>arrow-memory-netty</artifactId>
+            <version>${arrow.version}</version>
+        </dependency>
     </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-shade-plugin</artifactId>
+                <configuration>
+                    <relocations>
+                        <relocation>
+                            <pattern>org.apache.arrow</pattern>
+                            
<shadedPattern>com.starrocks.shaded.org.apache.arrow</shadedPattern>

Review Comment:
   already fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to