hailin0 commented on code in PR #4004:
URL:
https://github.com/apache/incubator-seatunnel/pull/4004#discussion_r1094126676
##########
seatunnel-connectors-v2/connector-fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeSourceReader.java:
##########
@@ -70,11 +70,8 @@ public void pollNext(Collector<SeaTunnelRow> output) throws
InterruptedException
synchronized (output.getCheckpointLock()) {
FakeSourceSplit split = splits.poll();
if (null != split) {
- // Generate a random number of rows to emit.
- List<SeaTunnelRow> seaTunnelRows =
fakeDataGenerator.generateFakedRows(split.getRowNum());
Review Comment:
update test cases
org.apache.seatunnel.connectors.seatunnel.fake.source.FakeDataGeneratorTest#testRowDataParse
```java
//List<SeaTunnelRow> seaTunnelRows =
fakeDataGenerator.generateFakedRows(fakeConfig.getRowNum());
List<SeaTunnelRow> seaTunnelRows = new ArrayList<>();
fakeDataGenerator.collectFakedRows(fakeConfig.getRowNum(), new
Collector<SeaTunnelRow>() {
@Override
public void collect(SeaTunnelRow record) {
seaTunnelRows.add(record);
}
@Override
public Object getCheckpointLock() {
throw new UnsupportedOperationException();
}
});
Assertions.assertIterableEquals(expected, seaTunnelRows);
```
##########
seatunnel-connectors-v2/connector-fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeSourceReader.java:
##########
@@ -70,11 +70,8 @@ public void pollNext(Collector<SeaTunnelRow> output) throws
InterruptedException
synchronized (output.getCheckpointLock()) {
FakeSourceSplit split = splits.poll();
if (null != split) {
- // Generate a random number of rows to emit.
- List<SeaTunnelRow> seaTunnelRows =
fakeDataGenerator.generateFakedRows(split.getRowNum());
Review Comment:
@zhilinli123
update test cases
org.apache.seatunnel.connectors.seatunnel.fake.source.FakeDataGeneratorTest#testRowDataParse
```java
//List<SeaTunnelRow> seaTunnelRows =
fakeDataGenerator.generateFakedRows(fakeConfig.getRowNum());
List<SeaTunnelRow> seaTunnelRows = new ArrayList<>();
fakeDataGenerator.collectFakedRows(fakeConfig.getRowNum(), new
Collector<SeaTunnelRow>() {
@Override
public void collect(SeaTunnelRow record) {
seaTunnelRows.add(record);
}
@Override
public Object getCheckpointLock() {
throw new UnsupportedOperationException();
}
});
Assertions.assertIterableEquals(expected, seaTunnelRows);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
