liugddx commented on code in PR #4059:
URL:
https://github.com/apache/incubator-seatunnel/pull/4059#discussion_r1096507406
##########
seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/disruptor/WALWorkHandler.java:
##########
@@ -78,6 +78,9 @@ private void walEvent(IMapFileData iMapFileData, WALEventType
type, long request
}
private void executeResponse(long requestId, boolean success) {
+ if (null == RequestFutureCache.get(requestId)) {
+ log.warn("requestId is {} not found in RequestFutureCache",
requestId);
+ }
Review Comment:
It can also cause a NPE if null . If it's null, maybe don't have to call
`RequestFutureCache.get(requestId).done(success);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
