TyrantLucifer commented on code in PR #3950:
URL:
https://github.com/apache/incubator-seatunnel/pull/3950#discussion_r1096890597
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/serialize/DefaultSeaTunnelRowSerializer.java:
##########
@@ -80,6 +82,8 @@ private static SerializationSchema
createSerializationSchema(SeaTunnelRowType ro
.seaTunnelRowType(rowType)
.delimiter(delimiter)
.build();
+ } else if (CANNAL_FORMAT.equals(format)) {
Review Comment:
switch is better
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java:
##########
@@ -210,6 +212,10 @@ private void setDeserialization(Config config) {
.seaTunnelRowType(typeInfo)
.delimiter(delimiter)
.build();
+ } else if (CANNAL_FORMAT.equals(format)) {
Review Comment:
The same as above.
##########
seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml:
##########
@@ -58,6 +58,21 @@
<artifactId>connector-console</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>connector-kafka</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>connector-jdbc</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>42.5.0</version>
+ </dependency>
Review Comment:
Aggre with @hailin0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
