ruanwenjun commented on code in PR #3939:
URL:
https://github.com/apache/incubator-seatunnel/pull/3939#discussion_r1098626414
##########
pom.xml:
##########
@@ -871,6 +820,77 @@
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
</plugin>
+
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless.version}</version>
+ <configuration>
+ <java>
+ <googleJavaFormat>
+ <version>1.7</version>
+ <style>AOSP</style>
+ </googleJavaFormat>
+ <removeUnusedImports />
+ <formatAnnotations />
+ <importOrder>
+
<order>org.apache.seatunnel.shade,org.apache.seatunnel,org.apache,org,,javax,java,\#</order>
+ </importOrder>
+ <replaceRegex>
+ <name>Remove wildcard imports</name>
+
<searchRegex>import\s+(static)*\s*[^\*\s]+\*;(\r\n|\r|\n)</searchRegex>
+ <replacement>$1</replacement>
+ </replaceRegex>
+ <replaceRegex>
+ <name>Block powermock</name>
+
<searchRegex>import\s+org\.powermock\.[^\*\s]*(|\*);(\r\n|\r|\n)</searchRegex>
+ <replacement>$1</replacement>
+ </replaceRegex>
+ <replaceRegex>
+ <name>Block jUnit4 imports</name>
+
<searchRegex>import\s+org\.junit\.[^jupiter][^\*\s]*(|\*);(\r\n|\r|\n)</searchRegex>
+ <replacement>$1</replacement>
+ </replaceRegex>
+ </java>
+ <pom>
+ <sortPom>
+ <encoding>UTF-8</encoding>
+ <nrOfIndentSpace>4</nrOfIndentSpace>
+ <keepBlankLines>true</keepBlankLines>
+ <indentBlankLines>false</indentBlankLines>
+ <indentSchemaLocation>true</indentSchemaLocation>
+
<spaceBeforeCloseEmptyElement>true</spaceBeforeCloseEmptyElement>
+ <sortModules>false</sortModules>
+ <sortExecutions>false</sortExecutions>
+ <predefinedSortOrder>custom_1</predefinedSortOrder>
+ <expandEmptyElements>false</expandEmptyElements>
+ <sortProperties>false</sortProperties>
+ </sortPom>
+ <replace>
+ <name>Leading blank line</name>
+ <search>project</search>
+ <replacement>project</replacement>
+ </replace>
+ </pom>
+ <markdown>
+ <includes>
+ <include>docs/**/*.md</include>
+ </includes>
+ <excludes>
+ <exclude>**/.github/**/*.md</exclude>
+ </excludes>
+ <flexmark />
+ </markdown>
Review Comment:
You can add upToDateChecking to improve the performance.
```java
<upToDateChecking>
<enabled>true</enabled>
</upToDateChecking>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
