EricJoy2048 commented on code in PR #21: URL: https://github.com/apache/incubator-seatunnel-web/pull/21#discussion_r1100035162
########## seatunnel-ui/.env.development: ########## @@ -15,4 +15,4 @@ NODE_ENV=development -VITE_APP_DEV_WEB_URL='' +VITE_APP_DEV_WEB_URL='http://127.0.0.1:8080' Review Comment: How about change the port? `8080` is too common and easy to conflict. ########## seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/controller/AuthController.java: ########## @@ -41,8 +41,8 @@ public class AuthController { @GetMapping("/userRole") @ApiOperation(value = "check relation between user and role", httpMethod = "GET") @ApiImplicitParams({ - @ApiImplicitParam(name = "username", value = "user name", dataType = "String"), - @ApiImplicitParam(name = "roleName", value = "role name", dataType = "String"), + @ApiImplicitParam(name = "username", value = "user name", dataType = "String"), Review Comment: revert? ########## seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/controller/ScriptController.java: ########## @@ -120,7 +120,7 @@ public Result<Void> updateScriptParam(@ApiParam(value = "script id", required = @GetMapping("/{scriptId}/param") @ApiOperation(value = "fetch script param", httpMethod = "GET") @ApiImplicitParams({ - @ApiImplicitParam(name = "id", value = "script id", dataType = "Integer"), + @ApiImplicitParam(name = "id", value = "script id", dataType = "Integer"), Review Comment: revert? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
