kpretty commented on code in PR #4076:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4076#discussion_r1102192246


##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client/EsRestClient.java:
##########
@@ -376,8 +376,7 @@ public Map<String, String> getFieldTypeMapping(String 
index, List<String> source
                     mapping = getFieldTypeMappingFromProperties(properties, 
source);
                 } else {
                     for (Iterator<JsonNode> iter = 
mappingsProperty.iterator(); iter.hasNext(); ) {
-                        JsonNode typeNode = iter.next();
-                        JsonNode properties = typeNode.get("properties");
+                        JsonNode properties = iter.next();

Review Comment:
   @TyrantLucifer Indeed, the mapping of es has changed, this problem has been 
fixed and the test has passed es5, es6, es7+
   
https://github.com/apache/incubator-seatunnel/blob/ac50b31ca3a534649cb90b467a7654f6e52f7180/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client/EsRestClient.java#L378-L387



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to