Hisoka-X commented on code in PR #3771: URL: https://github.com/apache/incubator-seatunnel/pull/3771#discussion_r1102317991
########## seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/jvm/TempDirectory.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.core.starter.seatunnel.jvm; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Arrays; + +/** + * Provides a path for a temporary directory. On non-Windows OS, this will be created as a sub-directory of the default temporary directory. + * Note that this causes the created temporary directory to be a private temporary directory. + */ +final class TempDirectory { + + /** + * The main entry point. The exit code is 0 if we successfully created a temporary directory as a sub-directory of the default + * temporary directory and printed the resulting path to the console. + * + * @param args the args to the program which should be empty + * @throws IOException if an I/O exception occurred while creating the temporary directory + */ + @SuppressWarnings("checkstyle:RegexpSingleline") + public static void main(final String[] args) throws IOException { + if (args.length != 0) { + throw new IllegalArgumentException("expected zero arguments but was " + Arrays.toString(args)); + } + /* + * On Windows, we avoid creating a unique temporary directory per invocation lest we pollute the temporary directory. On other + * operating systems, temporary directories will be cleaned automatically via various mechanisms (e.g., systemd, or restarts). + */ + final Path path; + if (System.getProperty("os.name").startsWith("Windows")) { + path = Paths.get(System.getProperty("java.io.tmpdir"), "seatunnel"); + Files.createDirectories(path); + } else { + path = Files.createTempDirectory("seatunnel-"); Review Comment: ```suggestion path = Files.createTempDirectory("seatunnel"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
