liugddx commented on code in PR #4153:
URL:
https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r1112004533
##########
bin/install-plugin.sh:
##########
@@ -43,61 +43,18 @@ if [ ! -d ${SEATUNNEL_HOME}/connectors ];
echo "create connectors directory"
fi
-# create the flink-sql connectors directory (for v1)
-if [ ! -d ${SEATUNNEL_HOME}/connectors/flink-sql ];
- then
- mkdir ${SEATUNNEL_HOME}/connectors/flink-sql
- echo "create flink-sql connectors directory"
-fi
-
-# create the flink connectors directory (for v1)
-if [ ! -d ${SEATUNNEL_HOME}/connectors/flink ];
- then
- mkdir ${SEATUNNEL_HOME}/connectors/flink
- echo "create flink connectors directory"
-fi
-
-# create the spark connectors directory (for v1)
-if [ ! -d ${SEATUNNEL_HOME}/connectors/spark ];
- then
- mkdir ${SEATUNNEL_HOME}/connectors/spark
- echo "create spark connectors directory"
-fi
-
# create the seatunnel connectors directory (for v2)
if [ ! -d ${SEATUNNEL_HOME}/connectors/seatunnel ];
then
mkdir ${SEATUNNEL_HOME}/connectors/seatunnel
echo "create seatunnel connectors directory"
fi
-path=flink-sql
-
while read line; do
- # v1 connectors flink-sql
- if [ "$line" = "--flink-sql-connectors--" ]
- then
- path=flink-sql
- fi
- # v1 connectors flink
- if [ "$line" = "--flink-connectors--" ]
- then
- path=flink
- fi
- # v1 connectors spark
- if [ "$line" = "--spark-connectors--" ]
- then
- path=spark
- fi
- # v2 connectors
- if [ "$line" = "--connectors-v2--" ]
- then
- path=seatunnel
- fi
if [ ${line:0:1} != "-" ] && [ ${line:0:1} != "#" ]
then
echo "install connector : " $line
- ${SEATUNNEL_HOME}/mvnw dependency:get
-DgroupId=org.apache.seatunnel -DartifactId=${line} -Dversion=${version}
-Ddest=${SEATUNNEL_HOME}/connectors/${path}
+ ${SEATUNNEL_HOME}/mvnw dependency:get
-DgroupId=org.apache.seatunnel -DartifactId=${line} -Dversion=${version}
-Ddest=${SEATUNNEL_HOME}/connectors
Review Comment:
```suggestion
${SEATUNNEL_HOME}/mvnw dependency:get
-DgroupId=org.apache.seatunnel -DartifactId=${line} -Dversion=${version}
-Ddest=${SEATUNNEL_HOME}/connectors/seatunnel
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
