TaoZex commented on code in PR #3981:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3981#discussion_r1124008002


##########
seatunnel-formats/seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/debezium/DebeziumJsonSerDeSchemaTest.java:
##########
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.format.json.debezium;
+
+import org.apache.seatunnel.api.source.Collector;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static org.apache.seatunnel.api.table.type.BasicType.FLOAT_TYPE;
+import static org.apache.seatunnel.api.table.type.BasicType.INT_TYPE;
+import static org.apache.seatunnel.api.table.type.BasicType.STRING_TYPE;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class DebeziumJsonSerDeSchemaTest {
+
+    private static final SeaTunnelRowType PHYSICAL_DATA_TYPE =
+            new SeaTunnelRowType(
+                    new String[] {"id", "name", "description", "weight"},
+                    new SeaTunnelDataType[] {INT_TYPE, STRING_TYPE, 
STRING_TYPE, FLOAT_TYPE});
+
+    @Test
+    void testNullRowMessages() throws Exception {
+        DebeziumJsonDeserializationSchema deserializationSchema =
+                new DebeziumJsonDeserializationSchema(PHYSICAL_DATA_TYPE, 
false, false);
+        SimpleCollector collector = new SimpleCollector();
+
+        deserializationSchema.deserialize(null, collector);
+        deserializationSchema.deserialize(new byte[0], collector);
+        assertEquals(0, collector.list.size());
+    }
+
+    @Test
+    public void testSerializationAndSchemaIncludeDeserialization() throws 
Exception {
+        testSerializationDeserialization("debezium-data-schema-include.txt", 
true);
+    }
+
+    @Test
+    public void testSerializationAndSchemaExcludeDeserialization() throws 
Exception {
+        testSerializationDeserialization("debezium-data-schema-exclude.txt", 
false);
+    }
+
+    private void testSerializationDeserialization(String resourceFile, boolean 
schemaInclude)
+            throws Exception {
+        List<String> lines = readLines(resourceFile);
+        DebeziumJsonDeserializationSchema deserializationSchema =
+                new DebeziumJsonDeserializationSchema(PHYSICAL_DATA_TYPE, 
schemaInclude, false);
+
+        SimpleCollector collector = new SimpleCollector();
+
+        for (String line : lines) {
+            
deserializationSchema.deserialize(line.getBytes(StandardCharsets.UTF_8), 
collector);
+        }
+
+        List<String> expected =
+                Arrays.asList(
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[101, 
scooter, Small 2-wheel scooter, 3.14]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[102, car 
battery, 12V car battery, 8.1]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[103, 
12-pack drill bits, 12-pack of drill bits with sizes ranging from #40 to #3, 
0.8]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[104, 
hammer, 12oz carpenter's hammer, 0.75]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[105, 
hammer, 14oz carpenter's hammer, 0.875]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[106, 
hammer, 16oz carpenter's hammer, 1.0]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[107, rocks, 
box of assorted rocks, 5.3]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[108, 
jacket, water resistent black wind breaker, 0.1]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[109, spare 
tire, 24 inch spare tire, 22.2]}",
+                        "SeaTunnelRow{tableId=-1, kind=-U, fields=[106, 
hammer, 16oz carpenter's hammer, 1.0]}",
+                        "SeaTunnelRow{tableId=-1, kind=+U, fields=[106, 
hammer, 18oz carpenter hammer, 1.0]}",
+                        "SeaTunnelRow{tableId=-1, kind=-U, fields=[107, rocks, 
box of assorted rocks, 5.3]}",
+                        "SeaTunnelRow{tableId=-1, kind=+U, fields=[107, rocks, 
box of assorted rocks, 5.1]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[110, 
jacket, water resistent white wind breaker, 0.2]}",
+                        "SeaTunnelRow{tableId=-1, kind=+I, fields=[111, 
scooter, Big 2-wheel scooter , 5.18]}",
+                        "SeaTunnelRow{tableId=-1, kind=-U, fields=[110, 
jacket, water resistent white wind breaker, 0.2]}",
+                        "SeaTunnelRow{tableId=-1, kind=+U, fields=[110, 
jacket, new water resistent white wind breaker, 0.5]}",
+                        "SeaTunnelRow{tableId=-1, kind=-U, fields=[111, 
scooter, Big 2-wheel scooter , 5.18]}",
+                        "SeaTunnelRow{tableId=-1, kind=+U, fields=[111, 
scooter, Big 2-wheel scooter , 5.17]}",
+                        "SeaTunnelRow{tableId=-1, kind=-D, fields=[111, 
scooter, Big 2-wheel scooter , 5.17]}");
+        List<String> actual =
+                
collector.list.stream().map(Object::toString).collect(Collectors.toList());
+        assertEquals(expected, actual);
+
+        DebeziumJsonSerializationSchema serializationSchema =
+                new DebeziumJsonSerializationSchema(PHYSICAL_DATA_TYPE);
+
+        actual = new ArrayList<>();
+        for (SeaTunnelRow rowData : collector.list) {
+            actual.add(new String(serializationSchema.serialize(rowData), 
StandardCharsets.UTF_8));
+        }
+
+        expected =
+                Arrays.asList(
+                        
"{\"before\":null,\"after\":{\"id\":101,\"name\":\"scooter\",\"description\":\"Small
 2-wheel scooter\",\"weight\":3.14},\"op\":\"c\"}",
+                        "{\"before\":null,\"after\":{\"id\":102,\"name\":\"car 
battery\",\"description\":\"12V car battery\",\"weight\":8.1},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":103,\"name\":\"12-pack drill 
bits\",\"description\":\"12-pack of drill bits with sizes ranging from #40 to 
#3\",\"weight\":0.8},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":104,\"name\":\"hammer\",\"description\":\"12oz
 carpenter's hammer\",\"weight\":0.75},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":105,\"name\":\"hammer\",\"description\":\"14oz
 carpenter's hammer\",\"weight\":0.875},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":106,\"name\":\"hammer\",\"description\":\"16oz
 carpenter's hammer\",\"weight\":1.0},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":107,\"name\":\"rocks\",\"description\":\"box
 of assorted rocks\",\"weight\":5.3},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":108,\"name\":\"jacket\",\"description\":\"water
 resistent black wind breaker\",\"weight\":0.1},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":109,\"name\":\"spare 
tire\",\"description\":\"24 inch spare tire\",\"weight\":22.2},\"op\":\"c\"}",
+                        
"{\"before\":{\"id\":106,\"name\":\"hammer\",\"description\":\"16oz carpenter's 
hammer\",\"weight\":1.0},\"after\":null,\"op\":\"d\"}",
+                        
"{\"before\":null,\"after\":{\"id\":106,\"name\":\"hammer\",\"description\":\"18oz
 carpenter hammer\",\"weight\":1.0},\"op\":\"c\"}",
+                        
"{\"before\":{\"id\":107,\"name\":\"rocks\",\"description\":\"box of assorted 
rocks\",\"weight\":5.3},\"after\":null,\"op\":\"d\"}",
+                        
"{\"before\":null,\"after\":{\"id\":107,\"name\":\"rocks\",\"description\":\"box
 of assorted rocks\",\"weight\":5.1},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":110,\"name\":\"jacket\",\"description\":\"water
 resistent white wind breaker\",\"weight\":0.2},\"op\":\"c\"}",
+                        
"{\"before\":null,\"after\":{\"id\":111,\"name\":\"scooter\",\"description\":\"Big
 2-wheel scooter \",\"weight\":5.18},\"op\":\"c\"}",
+                        
"{\"before\":{\"id\":110,\"name\":\"jacket\",\"description\":\"water resistent 
white wind breaker\",\"weight\":0.2},\"after\":null,\"op\":\"d\"}",
+                        
"{\"before\":null,\"after\":{\"id\":110,\"name\":\"jacket\",\"description\":\"new
 water resistent white wind breaker\",\"weight\":0.5},\"op\":\"c\"}",
+                        
"{\"before\":{\"id\":111,\"name\":\"scooter\",\"description\":\"Big 2-wheel 
scooter \",\"weight\":5.18},\"after\":null,\"op\":\"d\"}",
+                        
"{\"before\":null,\"after\":{\"id\":111,\"name\":\"scooter\",\"description\":\"Big
 2-wheel scooter \",\"weight\":5.17},\"op\":\"c\"}",
+                        
"{\"before\":{\"id\":111,\"name\":\"scooter\",\"description\":\"Big 2-wheel 
scooter \",\"weight\":5.17},\"after\":null,\"op\":\"d\"}");
+        assertEquals(expected, actual);
+    }
+    // 
--------------------------------------------------------------------------------------------
+    // Utilities
+    // 
--------------------------------------------------------------------------------------------
+
+    private static List<String> readLines(String resource) throws IOException {
+        final URL url = 
DebeziumJsonSerDeSchemaTest.class.getClassLoader().getResource(resource);
+        assert url != null;

Review Comment:
   Done. Thanks for your advice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to