TyrantLucifer commented on code in PR #4235: URL: https://github.com/apache/incubator-seatunnel/pull/4235#discussion_r1127515097
########## seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/sink/writer/DorisSinkWriter.java: ########## @@ -0,0 +1,273 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: The same as above. ########## docs/en/connector-v2/sink/Doris.md: ########## @@ -9,29 +9,25 @@ The internal implementation of Doris sink connector is cached and imported by st ## Key features -- [ ] [exactly-once](../../concept/connector-v2-features.md) +- [x] [exactly-once](../../concept/connector-v2-features.md) +- [x] [cdc](../../concept/connector-v2-features.md) ## Options -| name | type | required | default value | -|-----------------------------|--------|----------|-----------------| -| node_urls | list | yes | - | -| username | string | yes | - | -| password | string | yes | - | -| database | string | yes | - | -| table | string | yes | - | -| labelPrefix | string | no | - | -| batch_max_rows | long | no | 1024 | -| batch_max_bytes | int | no | 5 * 1024 * 1024 | -| batch_interval_ms | int | no | 1000 | -| max_retries | int | no | 1 | -| retry_backoff_multiplier_ms | int | no | - | -| max_retry_backoff_ms | int | no | - | -| doris.config | map | no | - | - -### node_urls [list] - -`Doris` cluster address, the format is `["fe_ip:fe_http_port", ...]` +| name | type | required | default value | +|--------------------|--------|----------|---------------| +| fenodes | string | yes | - | +| username | string | yes | - | +| password | string | yes | - | +| table.identifier | string | yes | - | +| sink.label-prefix | string | yes | - | +| sink.enable-2pc | bool | no | true | +| sink.enable-delete | bool | no | false | +| doris.config | map | yes | - | + +### node_urls [string] Review Comment: Means that `fenodes`? ########## seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/sink/writer/DorisSinkState.java: ########## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: `/**` is better ########## seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/sink/writer/LabelGenerator.java: ########## @@ -0,0 +1,35 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: The same as above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
