iture123 commented on code in PR #4233:
URL:
https://github.com/apache/incubator-seatunnel/pull/4233#discussion_r1140900039
##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/source/DefaultSeaTunnelRowDeserializer.java:
##########
@@ -150,7 +158,8 @@ Object convertValue(SeaTunnelDataType<?> fieldType, String
fieldValue)
LocalDateTime localDateTime = parseDate(fieldValue);
return localDateTime.toLocalTime();
} else if (LocalTimeType.LOCAL_DATE_TIME_TYPE.equals(fieldType)) {
Review Comment:
ES support Multiple date formats, and you should enhance it without removing
the old implementation.ES date type can be defined as follows
{
"type": "date",
"format": "yyyy-MM-dd HH:mm:ss||yyyy-MM-dd||epoch_millis"
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
