zhilinli123 commented on code in PR #4349:
URL:
https://github.com/apache/incubator-seatunnel/pull/4349#discussion_r1141587066
##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/config/SinkConfig.java:
##########
@@ -58,6 +58,13 @@ public class SinkConfig {
.defaultValue(10)
.withDescription("batch bulk doc max size");
+ @SuppressWarnings("checkstyle:MagicNumber")
+ public static final Option<Integer> BATCH_INTERVAL_MS =
+ Options.key("batch_interval_ms")
+ .intType()
+ .defaultValue(1000)
Review Comment:
> It is better set defualtValue is 0 ?
For this time setting, I refer to flink I think it's a little more user
friendly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
