EricJoy2048 commented on code in PR #4372:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4372#discussion_r1149941247


##########
docs/en/connector-v2/source/Http.md:
##########
@@ -289,6 +293,32 @@ Http {
 }
 ```
 
+### page options
+
+## Example
+
+simple:
+
+```hocon
+Http {
+  url = "https://tyrantlucifer.com/api/getDemoData";
+  pageing = {
+    pageNoField = "pageNo",
+    pageNo = "1-2,4,8-10",

Review Comment:
   > Connector how to know the total page size of the interface? Different 
interfaces have different standard method the expose the total pages size, so 
in connector side we only should offer the config options to tell connector 
what page number it need read.
   
   We add `pageNoField ` to map which field is a page, why not add a parameter 
to let the user specify which is a totalPage field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to