EricJoy2048 commented on code in PR #4469:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4469#discussion_r1155065452


##########
seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml:
##########
@@ -67,6 +67,11 @@
             <artifactId>connector-console</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>

Review Comment:
   Please revert this. Otherwise, there will be a license issue.



##########
seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/resources/examples/fake_to_kafka.conf:
##########
@@ -0,0 +1,34 @@
+env {

Review Comment:
   Please revert this file. In fact we already ignore the file add in 
`seatunnel-examples` module from `.gitignore` file. I don't know why it seems 
not work in your pull request.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to