cswangzheng commented on code in PR #4439:
URL:
https://github.com/apache/incubator-seatunnel/pull/4439#discussion_r1160396644
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java:
##########
@@ -236,6 +237,6 @@ private PartitionParameter
initPartitionParameterAndExtendSql(Connection connect
}
private boolean isNumericType(SeaTunnelDataType<?> type) {
- return type.equals(BasicType.INT_TYPE) ||
type.equals(BasicType.LONG_TYPE);
+ return type.equals(BasicType.INT_TYPE) ||
type.equals(BasicType.LONG_TYPE) || type instanceof DecimalType;
Review Comment:
but in most case, like in Oracle, the default number type's precision is 38，
which will map to Decimal type in seatunnel. It should be better to throw
exception when init split param than reject split in the first time.
isNumericType will also throw exception, but it is much earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
