hailin0 commented on code in PR #4542:
URL:
https://github.com/apache/incubator-seatunnel/pull/4542#discussion_r1162262721
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/debezium/utils/TemporalConversions.java:
##########
@@ -66,6 +67,9 @@ public static LocalDate toLocalDate(Object obj) {
return LocalDate.of(date.getYear() + 1900, date.getMonth() + 1,
date.getDate());
}
if (obj instanceof Long) {
+ if ((Long)obj > ChronoField.EPOCH_DAY.range().getMaximum()) {
Review Comment:
fix millisecond
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/debezium/row/SeaTunnelRowDebeziumDeserializeSchema.java:
##########
@@ -128,7 +128,7 @@ public void deserialize(SourceRecord record,
Collector<SeaTunnelRow> collector)
} catch (Throwable e) {
// ignore
}
- String tableId = TablePath.of(databaseName, schemaName,
tableName).toString();
+ String tableId = TablePath.of(databaseName, schemaName,
tableName).toString().toUpperCase();
Review Comment:
SeaTunnelRow#tableId using uppercase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
