TyrantLucifer commented on code in PR #4389:
URL:
https://github.com/apache/incubator-seatunnel/pull/4389#discussion_r1167975623
##########
seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/resources/examples/fake_to_console.conf:
##########
@@ -18,14 +18,6 @@
###### This config file is a demonstration of streaming processing in
seatunnel config
######
-env {
Review Comment:
Why change it?
##########
seatunnel-examples/seatunnel-engine-examples/pom.xml:
##########
@@ -62,5 +62,10 @@
<artifactId>connector-console</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Why change it?
##########
seatunnel-dist/pom.xml:
##########
@@ -353,6 +353,12 @@
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>connector-mongodb-v2</artifactId>
Review Comment:
No v2, delete old codes.
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-mongodb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/v2/mongodb/MongodbIT.java:
##########
@@ -53,18 +44,23 @@
import java.io.IOException;
import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
import java.time.Duration;
-import java.time.LocalDate;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.Arrays;
+import java.util.Date;
import java.util.List;
+import java.util.Random;
import java.util.concurrent.TimeUnit;
import java.util.stream.Stream;
import static java.net.HttpURLConnection.HTTP_OK;
import static java.net.HttpURLConnection.HTTP_UNAUTHORIZED;
@Slf4j
+@DisabledOnContainer(
+ value = {},
+ type = {EngineType.FLINK, EngineType.SPARK})
Review Comment:
Why disabled flink and spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
