Hisoka-X commented on issue #4587:
URL:
https://github.com/apache/incubator-seatunnel/issues/4587#issuecomment-1510607666
> so it is necessary to make Config support serialization to ensure that it
is not lost during transmission.
Why not use `ReadonlyConfig`? I think we would remove use config in
connector layer in the future.
> Before instantiating the Sink, merge the plugin configuration for all
Sinks, and merge the dirty data collector configuration information from the
env section into the plugin configuration.
I think sink should not care about dirty data collector config. Why not
just use env config to create `DirtyRecordCollector ` then put it into
`context`? And Any dirty data collector config should be handle in
`DirtyRecordCollector `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
