hailin0 commented on code in PR #4698:
URL:
https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1184473318
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:
##########
@@ -130,6 +132,24 @@ public void pollNext(Collector<SeaTunnelRow> output)
throws Exception {
}
}
+ /**
+ * deal lineData
+ *
+ * @param output
+ * @param data
+ * @throws IOException
+ */
+ private void dealLineData(Collector<SeaTunnelRow> output, String data)
throws IOException {
Review Comment:
```suggestion
private void collect(Collector<SeaTunnelRow> output, String data) throws
IOException {
```
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -83,6 +84,13 @@ public class HttpConfig {
.withDescription(
"SeaTunnel content field.This parameter can get
some json data, and there is no need to configure each field separately.");
+ public static final Option<Boolean> ENABLEMULTILINES =
Review Comment:
```suggestion
public static final Option<Boolean> ENABLE_MULTI_LINES =
```
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:
##########
@@ -130,6 +132,24 @@ public void pollNext(Collector<SeaTunnelRow> output)
throws Exception {
}
}
+ /**
+ * deal lineData
+ *
+ * @param output
+ * @param data
+ * @throws IOException
+ */
Review Comment:
```suggestion
```
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -17,23 +17,24 @@ Used to read data from Http.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| schema | Config | No | - |
-| schema.fields | Config | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| format | String | No | json |
-| method | String | No | get |
-| headers | Map | No | - |
-| params | Map | No | - |
-| body | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| schema | Config | No | - |
+| schema.fields | Config | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| format | String | No | json |
+| method | String | No | get |
+| headers | Map | No | - |
+| params | Map | No | - |
+| body | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
Is this setting required for connectors other than http?
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -83,6 +84,13 @@ public class HttpConfig {
.withDescription(
"SeaTunnel content field.This parameter can get
some json data, and there is no need to configure each field separately.");
+ public static final Option<Boolean> ENABLEMULTILINES =
+ Options.key("enableMultiLines")
Review Comment:
```suggestion
Options.key("enable_multi_lines")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
