Hisoka-X commented on code in PR #4757:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4757#discussion_r1193645970


##########
docs/en/connector-v2/source/PostgreSQL.md:
##########
@@ -0,0 +1,157 @@
+# PostgreSQL
+
+> JDBC PostgreSQL Source Connector
+
+## Support Those Engines
+
+> Spark<br/>
+> Flink<br/>
+> Seatunnel Zeta<br/>
+
+## Key Features
+
+- [x] [batch](../../concept/connector-v2-features.md)
+- [ ] [stream](../../concept/connector-v2-features.md)
+- [x] [exactly-once](../../concept/connector-v2-features.md)
+- [x] [column projection](../../concept/connector-v2-features.md)
+- [x] [parallelism](../../concept/connector-v2-features.md)
+- [x] [support user-defined split](../../concept/connector-v2-features.md)
+
+> supports query SQL and can achieve projection effect.
+
+## Description
+
+Read external data source data through JDBC.
+
+## Supported DataSource Info
+
+| Datasource |                    Supported versions                    |      
  Driver         |                  Url                  |                      
            Maven                                   |
+|------------|----------------------------------------------------------|-----------------------|---------------------------------------|--------------------------------------------------------------------------|
+| PostgreSQL | Different dependency version has different driver class. | 
org.postgresql.Driver | jdbc:postgresql://localhost:5432/test | 
[Download](https://mvnrepository.com/artifact/org.postgresql/postgresql) |
+
+## Database Dependency
+
+> Please download the support list corresponding to 'Maven' and copy it to the 
'$SEATNUNNEL_HOME/plugins/jdbc/lib/' working directory<br/>
+> For example PostgreSQL datasource: cp postgresql-xxx.jar 
$SEATNUNNEL_HOME/plugins/jdbc/lib/
+
+## Data Type Mapping
+
+|                     PostgreSQL Data type                     |               
                                               Seatunnel Data type              
                                                 |
+|--------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------|
+| BOOL<BR/>                                                    | BOOLEAN       
                                                                                
                                                 |
+| _BOOL<BR/>                                                   | 
ARRAY&LT;BOOLEAN&GT;                                                            
                                                               |
+| BYTEA<BR/>                                                   | BYTES         
                                                                                
                                                 |
+| _BYTEA<BR/>                                                  | 
ARRAY&LT;TINYINT&GT;                                                            
                                                               |
+| INT2<BR/>SMALLSERIAL<BR/>INT4<BR/>SERIAL<BR/>                | INT           
                                                                                
                                                 |
+| _INT2<BR/>_INT4<BR/>                                         | 
ARRAY&LT;INT&GT;                                                                
                                                               |
+| INT8<BR/>BIGSERIAL<BR/>                                      | BIGINT        
                                                                                
                                                 |
+| _INT8<BR/>                                                   | 
ARRAY&LT;BIGINT&GT;                                                             
                                                               |
+| FLOAT4<BR/>                                                  | FLOAT         
                                                                                
                                                 |
+| _FLOAT4<BR/>                                                 | 
ARRAY&LT;FLOAT&GT;                                                              
                                                               |
+| FLOAT8<BR/>                                                  | DOUBLE        
                                                                                
                                                 |
+| _FLOAT8<BR/>                                                 | 
ARRAY&LT;DOUBLE&GT;                                                             
                                                               |
+| NUMERIC(Get the designated column's specified column size>0) | DECIMAL(Get 
the designated column's specified column size,Gets the number of digits in the 
specified column to the right of the decimal point) |
+| NUMERIC(Get the designated column's specified column size<0) | DECIMAL(38, 
18)                                                                             
                                                   |
+| BPCHAR<BR/>CHARACTER<BR/>VARCHAR<BR/>TEXT                    | STRING        
                                                                                
                                                 |
+| _BPCHAR<BR/>_CHARACTER<BR/>_VARCHAR<BR/>_TEXT                | 
ARRAY&LT;STRING&GT;                                                             
                                                               |
+| TIMESTAMP<BR/>                                               | TIMESTAMP     
                                                                                
                                                 |
+| TIME<BR/>                                                    | TIME          
                                                                                
                                                 |
+| DATE<BR/>                                                    | DATE          
                                                                                
                                                 |
+| OTHER DATA TYPES                                             | NOT SUPPORTED 
YET                                                                             
                                                 |
+
+## Options
+
+|             Name             |  Type  | Required |     Default     |         
                                                                                
                                   Description                                  
                                                                                
          |
+|------------------------------|--------|----------|-----------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| url                          | String | Yes      | -               | The URL 
of the JDBC connection. Refer to a case: jdbc:postgresql://localhost:5432/test  
                                                                                
                                                                                
          |
+| driver                       | String | Yes      | -               | The 
jdbc class name used to connect to the remote data source,<br/> if you use 
PostgreSQL the value is `org.postgresql.Driver`.                                
                                                                                
                   |
+| user                         | String | No       | -               | 
Connection instance user name                                                   
                                                                                
                                                                                
                  |
+| password                     | String | No       | -               | 
Connection instance password                                                    
                                                                                
                                                                                
                  |
+| query                        | String | Yes      | -               | Query 
statement                                                                       
                                                                                
                                                                                
            |
+| connection_check_timeout_sec | Int    | No       | 30              | The 
time in seconds to wait for the database operation used to validate the 
connection to complete                                                          
                                                                                
                      |
+| partition_column             | String | No       | -               | The 
column name for parallelism's partition, only support numeric type,Only support 
numeric type primary key, and only can config one column.                       
                                                                                
              |
+| partition_lower_bound        | Long   | No       | -               | The 
partition_column min value for scan, if not set SeaTunnel will query database 
get min value.                                                                  
                                                                                
                |
+| partition_upper_bound        | Long   | No       | -               | The 
partition_column max value for scan, if not set SeaTunnel will query database 
get max value.                                                                  
                                                                                
                |
+| partition_num                | Int    | No       | job parallelism | The 
number of partition count, only support positive integer. default value is job 
parallelism                                                                     
                                                                                
               |
+| fetch_size                   | Int    | No       | 0               | For 
queries that return a large number of objects,you can configure<br/> the row 
fetch size used in the query toimprove performance by<br/> reducing the number 
database hits required to satisfy the selection criteria.<br/> Zero means use 
jdbc default value. |
+| common-options               |        | No       | -               | Source 
plugin common parameters, please refer to [Source Common 
Options](common-options.md) for details                                         
                                                                                
                                  |
+
+### Tips
+
+> If partition_column is not set, it will run in single concurrency, and if 
partition_column is set, it will be executed  in parallel according to the 
concurrency of tasks.
+
+## Task Example
+
+### Simple:
+
+> This example queries type_bin 'table' 16 data in your test "database" in 
single parallel and queries all of its fields. You can also specify which 
fields to query for final output to the console.
+
+```
+# Defining the runtime environment
+env {
+  # You can set flink configuration here
+  execution.parallelism = 2
+  job.mode = "BATCH"
+}
+
+source{
+    Jdbc {
+        url = "jdbc:postgresql://localhost:5432/test"
+        driver = "org.postgresql.Driver"
+        user = "root"
+        password = "test"
+        query = "select * from source limit 16"
+    }
+}
+
+transform {
+    # If you would like to get more information about how to configure 
seatunnel and see full list of transform plugins,

Review Comment:
   same as above



##########
docs/en/connector-v2/sink/PostgreSql.md:
##########
@@ -0,0 +1,179 @@
+# PostgreSql
+
+> JDBC PostgreSql Sink Connector
+
+## Support Those Engines
+
+> Spark<br/>
+> Flink<br/>
+> Seatunnel Zeta<br/>
+
+## Key Features
+
+- [x] [exactly-once](../../concept/connector-v2-features.md)
+- [x] [cdc](../../concept/connector-v2-features.md)
+
+> Use `Xa transactions` to ensure `exactly-once`. So only support 
`exactly-once` for the database which is
+> support `Xa transactions`. You can set `is_exactly_once=true` to enable it.
+
+## Description
+
+Write data through jdbc. Support Batch mode and Streaming mode, support 
concurrent writing, support exactly-once
+semantics (using XA transaction guarantee).
+
+## Supported DataSource Info
+
+| Datasource |                    Supported Versions                    |      
  Driver         |                  Url                  |                      
            Maven                                   |
+|------------|----------------------------------------------------------|-----------------------|---------------------------------------|--------------------------------------------------------------------------|
+| PostgreSQL | Different dependency version has different driver class. | 
org.postgresql.Driver | jdbc:postgresql://localhost:5432/test | 
[Download](https://mvnrepository.com/artifact/org.postgresql/postgresql) |
+
+## Database Dependency
+
+> Please download the support list corresponding to 'Maven' and copy it to the 
'$SEATNUNNEL_HOME/plugins/jdbc/lib/' working directory<br/>
+> For example PostgreSQL datasource: cp postgresql-xxx.jar 
$SEATNUNNEL_HOME/plugins/jdbc/lib/
+
+## Data Type Mapping
+
+|                     PostgreSQL Data type                     |               
                                               Seatunnel Data type              
                                                 |
+|--------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------|
+| BOOL<BR/>                                                    | BOOLEAN       
                                                                                
                                                 |
+| _BOOL<BR/>                                                   | 
ARRAY&LT;BOOLEAN&GT;                                                            
                                                               |
+| BYTEA<BR/>                                                   | BYTES         
                                                                                
                                                 |
+| _BYTEA<BR/>                                                  | 
ARRAY&LT;TINYINT&GT;                                                            
                                                               |
+| INT2<BR/>SMALLSERIAL<BR/>INT4<BR/>SERIAL<BR/>                | INT           
                                                                                
                                                 |
+| _INT2<BR/>_INT4<BR/>                                         | 
ARRAY&LT;INT&GT;                                                                
                                                               |
+| INT8<BR/>BIGSERIAL<BR/>                                      | BIGINT        
                                                                                
                                                 |
+| _INT8<BR/>                                                   | 
ARRAY&LT;BIGINT&GT;                                                             
                                                               |
+| FLOAT4<BR/>                                                  | FLOAT         
                                                                                
                                                 |
+| _FLOAT4<BR/>                                                 | 
ARRAY&LT;FLOAT&GT;                                                              
                                                               |
+| FLOAT8<BR/>                                                  | DOUBLE        
                                                                                
                                                 |
+| _FLOAT8<BR/>                                                 | 
ARRAY&LT;DOUBLE&GT;                                                             
                                                               |
+| NUMERIC(Get the designated column's specified column size>0) | DECIMAL(Get 
the designated column's specified column size,Gets the number of digits in the 
specified column to the right of the decimal point) |
+| NUMERIC(Get the designated column's specified column size<0) | DECIMAL(38, 
18)                                                                             
                                                   |
+| BPCHAR<BR/>CHARACTER<BR/>VARCHAR<BR/>TEXT                    | STRING        
                                                                                
                                                 |
+| _BPCHAR<BR/>_CHARACTER<BR/>_VARCHAR<BR/>_TEXT                | 
ARRAY&LT;STRING&GT;                                                             
                                                               |
+| TIMESTAMP<BR/>                                               | TIMESTAMP     
                                                                                
                                                 |
+| TIME<BR/>                                                    | TIME          
                                                                                
                                                 |
+| DATE<BR/>                                                    | DATE          
                                                                                
                                                 |
+| OTHER DATA TYPES                                             | NOT SUPPORTED 
YET                                                                             
                                                 |
+
+## Options
+
+|                   name                    |  type   | required | default 
value |                                                                         
                                        description                             
                                                                                
     |
+|-------------------------------------------|---------|----------|---------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| url                                       | String  | Yes      | -           
  | The URL of the JDBC connection. Refer to a case: 
jdbc:postgresql://localhost:5432/test                                           
                                                                                
                            |
+| driver                                    | String  | Yes      | -           
  | The jdbc class name used to connect to the remote data source,<br/> if you 
use PostgreSQL the value is `org.postgresql.Driver`.                            
                                                                                
  |
+| user                                      | String  | No       | -           
  | Connection instance user name                                               
                                                                                
                                                                                
 |
+| password                                  | String  | No       | -           
  | Connection instance password                                                
                                                                                
                                                                                
 |
+| query                                     | String  | No       | -           
  | Use this sql write upstream input datas to database. e.g `INSERT 
...`,`query` have the higher priority                                           
                                                                                
            |
+| database                                  | String  | No       | -           
  | Use this `database` and `table-name` auto-generate sql and receive upstream 
input datas write to database.<br/>This option is mutually exclusive with 
`query` and has a higher priority.                                              
       |
+| table                                     | String  | No       | -           
  | Use database and this table-name auto-generate sql and receive upstream 
input datas write to database.<br/>This option is mutually exclusive with 
`query` and has a higher priority.                                              
           |
+| primary_keys                              | Array   | No       | -           
  | This option is used to support operations such as `insert`, `delete`, and 
`update` when automatically generate sql.                                       
                                                                                
   |
+| support_upsert_by_query_primary_key_exist | Boolean | No       | false       
  | Choose to use INSERT sql, UPDATE sql to process update events(INSERT, 
UPDATE_AFTER) based on query primary key exists. This configuration is only 
used when database unsupport upsert syntax. **Note**: that this method has low 
performance |
+| connection_check_timeout_sec              | Int     | No       | 30          
  | The time in seconds to wait for the database operation used to validate the 
connection to complete.                                                         
                                                                                
 |
+| max_retries                               | Int     | No       | 0           
  | The number of retries to submit failed (executeBatch)                       
                                                                                
                                                                                
 |
+| batch_size                                | Int     | No       | 1000        
  | For batch writing, when the number of buffered records reaches the number 
of `batch_size` or the time reaches `batch_interval_ms`<br/>, the data will be 
flushed into the database                                                       
    |
+| batch_interval_ms                         | Int     | No       | 1000        
  | For batch writing, when the number of buffers reaches the number of 
`batch_size` or the time reaches `batch_interval_ms`, the data will be flushed 
into the database                                                               
          |
+| is_exactly_once                           | Boolean | No       | false       
  | Whether to enable exactly-once semantics, which will use Xa transactions. 
If on, you need to<br/>set `xa_data_source_class_name`.                         
                                                                                
   |
+| xa_data_source_class_name                 | String  | No       | -           
  | The xa data source class name of the database Driver, for example, 
PostgreSQL is `org.postgresql.xa.PGXADataSource`, and<br/>please refer to 
appendix for other data sources                                                 
                |
+| max_commit_attempts                       | Int     | No       | 3           
  | The number of retries for transaction commit failures                       
                                                                                
                                                                                
 |
+| transaction_timeout_sec                   | Int     | No       | -1          
  | The timeout after the transaction is opened, the default is -1 (never 
timeout). Note that setting the timeout may affect<br/>exactly-once semantics   
                                                                                
       |
+| auto_commit                               | Boolean | No       | true        
  | Automatic transaction commit is enabled by default                          
                                                                                
                                                                                
 |
+| common-options                            |         | no       | -           
  | Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details                                         
                                                                                
                 |
+
+### Tips
+
+> If partition_column is not set, it will run in single concurrency, and if 
partition_column is set, it will be executed  in parallel according to the 
concurrency of tasks.
+
+## Task Example
+
+### Simple:
+
+> This example defines a SeaTunnel synchronization task that automatically 
generates data through FakeSource and sends it to JDBC Sink. FakeSource 
generates a total of 16 rows of data (row.num=16), with each row having two 
fields, name (string type) and age (int type). The final target table is 
test_table will also be 16 rows of data in the table. Before run this job, you 
need create database test and table test_table in your PostgreSQL. And if you 
have not yet installed and deployed SeaTunnel, you need to follow the 
instructions in [Install SeaTunnel](../../start-v2/locally/deployment.md) to 
install and deploy SeaTunnel. And then follow the instructions in [Quick Start 
With SeaTunnel Engine](../../start-v2/locally/quick-start-seatunnel-engine.md) 
to run this job.
+
+```
+# Defining the runtime environment
+env {
+  # You can set flink configuration here
+  execution.parallelism = 1
+  job.mode = "BATCH"
+}
+
+source {
+  # This is a example source plugin **only for test and demonstrate the 
feature source plugin**

Review Comment:
   Please remove comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to