liugddx commented on code in PR #4764:
URL:
https://github.com/apache/incubator-seatunnel/pull/4764#discussion_r1197468971
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -180,7 +182,6 @@ public void close() throws IOException {
public void addSplitsBack(List<KafkaSourceSplit> splits, int subtaskId) {
if (!splits.isEmpty()) {
pendingSplit.putAll(convertToNextSplit(splits));
- assignSplit();
Review Comment:
`addSplitsBack()` shouldn't do the assign split, it lags behind
`registeredReaders()`. In addition, run() will assign split again and it is run
in the next stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]