hailin0 commented on code in PR #4634:
URL:
https://github.com/apache/incubator-seatunnel/pull/4634#discussion_r1198670979
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcMysqlIT.java:
##########
@@ -194,11 +200,16 @@ Pair<String[], List<SeaTunnelRow>> initTestData() {
};
List<SeaTunnelRow> rows = new ArrayList<>();
+ BigDecimal bigintValue = new BigDecimal("2844674407371055000");
+ BigDecimal decimalValue = new
BigDecimal("999999999999999999999999999899");
for (int i = 0; i < 100; i++) {
byte byteArr = Integer.valueOf(i).byteValue();
SeaTunnelRow row =
new SeaTunnelRow(
new Object[] {
+ bigintValue.add(BigDecimal.valueOf(i)),
+ decimalValue.add(BigDecimal.valueOf(i)),
+ decimalValue.add(BigDecimal.valueOf(i)),
Review Comment:
move to end
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcMysqlIT.java:
##########
@@ -150,6 +153,9 @@ String driverUrl() {
Pair<String[], List<SeaTunnelRow>> initTestData() {
String[] fieldNames =
new String[] {
+ "c_bigint_30",
+ "c_decimal_unsigned_30",
+ "c_decimal_30",
Review Comment:
move to end
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_mysql_source_and_sink_parallel_upper_lower.conf:
##########
@@ -46,12 +46,12 @@ sink {
user = "root"
password = "Abc!@#135_seatunnel"
connection_check_timeout_sec = 100
- query = """insert into sink (c_bit_1, c_bit_8, c_bit_16, c_bit_32,
c_bit_64, c_boolean, c_tinyint, c_tinyint_unsigned, c_smallint,
c_smallint_unsigned,
+ query = """insert into sink
(c_bigint_30,c_decimal_unsigned_30,c_decimal_30,c_bit_1, c_bit_8, c_bit_16,
c_bit_32, c_bit_64, c_boolean, c_tinyint, c_tinyint_unsigned, c_smallint,
c_smallint_unsigned,
Review Comment:
move to end
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_mysql_source_and_sink_parallel.conf:
##########
@@ -45,12 +45,12 @@ sink {
user = "root"
password = "Abc!@#135_seatunnel"
connection_check_timeout_sec = 100
- query = """insert into sink (c_bit_1, c_bit_8, c_bit_16, c_bit_32,
c_bit_64, c_boolean, c_tinyint, c_tinyint_unsigned, c_smallint,
c_smallint_unsigned,
+ query = """insert into sink
(c_bigint_30,c_decimal_unsigned_30,c_decimal_30,c_bit_1, c_bit_8, c_bit_16,
c_bit_32, c_bit_64, c_boolean, c_tinyint, c_tinyint_unsigned, c_smallint,
c_smallint_unsigned,
Review Comment:
move to end
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_mysql_source_and_sink.conf:
##########
@@ -42,12 +42,12 @@ sink {
user = "root"
password = "Abc!@#135_seatunnel"
- query = """insert into sink (c_bit_1, c_bit_8, c_bit_16, c_bit_32,
c_bit_64, c_boolean, c_tinyint, c_tinyint_unsigned, c_smallint,
c_smallint_unsigned,
+ query = """insert into sink
(c_bigint_30,c_decimal_unsigned_30,c_decimal_30,c_bit_1, c_bit_8, c_bit_16,
c_bit_32, c_bit_64, c_boolean, c_tinyint, c_tinyint_unsigned, c_smallint,
c_smallint_unsigned,
Review Comment:
move to end
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcMysqlIT.java:
##########
@@ -64,47 +64,50 @@ public class JdbcMysqlIT extends AbstractJdbcIT {
private static final String CREATE_SQL =
"CREATE TABLE IF NOT EXISTS %s\n"
+ "(\n"
- + " `c_bit_1` bit(1)
DEFAULT NULL,\n"
- + " `c_bit_8` bit(8)
DEFAULT NULL,\n"
- + " `c_bit_16` bit(16)
DEFAULT NULL,\n"
- + " `c_bit_32` bit(32)
DEFAULT NULL,\n"
- + " `c_bit_64` bit(64)
DEFAULT NULL,\n"
- + " `c_boolean` tinyint(1)
DEFAULT NULL,\n"
- + " `c_tinyint` tinyint(4)
DEFAULT NULL,\n"
- + " `c_tinyint_unsigned` tinyint(3) unsigned
DEFAULT NULL,\n"
- + " `c_smallint` smallint(6)
DEFAULT NULL,\n"
- + " `c_smallint_unsigned` smallint(5) unsigned
DEFAULT NULL,\n"
- + " `c_mediumint` mediumint(9)
DEFAULT NULL,\n"
- + " `c_mediumint_unsigned` mediumint(8) unsigned
DEFAULT NULL,\n"
- + " `c_int` int(11)
DEFAULT NULL,\n"
- + " `c_integer` int(11)
DEFAULT NULL,\n"
- + " `c_bigint` bigint(20)
DEFAULT NULL,\n"
- + " `c_bigint_unsigned` bigint(20) unsigned
DEFAULT NULL,\n"
- + " `c_decimal` decimal(20, 0)
DEFAULT NULL,\n"
- + " `c_decimal_unsigned` decimal(38, 18)
DEFAULT NULL,\n"
- + " `c_float` float
DEFAULT NULL,\n"
- + " `c_float_unsigned` float unsigned
DEFAULT NULL,\n"
- + " `c_double` double
DEFAULT NULL,\n"
- + " `c_double_unsigned` double unsigned
DEFAULT NULL,\n"
- + " `c_char` char(1)
DEFAULT NULL,\n"
- + " `c_tinytext` tinytext,\n"
- + " `c_mediumtext` mediumtext,\n"
- + " `c_text` text,\n"
- + " `c_varchar` varchar(255)
DEFAULT NULL,\n"
- + " `c_json` json
DEFAULT NULL,\n"
- + " `c_longtext` longtext,\n"
- + " `c_date` date
DEFAULT NULL,\n"
- + " `c_datetime` datetime
DEFAULT NULL,\n"
- + " `c_timestamp` timestamp NULL
DEFAULT NULL,\n"
- + " `c_tinyblob` tinyblob,\n"
- + " `c_mediumblob` mediumblob,\n"
- + " `c_blob` blob,\n"
- + " `c_longblob` longblob,\n"
- + " `c_varbinary` varbinary(255)
DEFAULT NULL,\n"
- + " `c_binary` binary(1)
DEFAULT NULL,\n"
- + " `c_year` year(4)
DEFAULT NULL,\n"
- + " `c_int_unsigned` int(10) unsigned
DEFAULT NULL,\n"
- + " `c_integer_unsigned` int(10) unsigned
DEFAULT NULL\n"
+ + " `c_bigint_30` BIGINT(40) unsigned
DEFAULT NULL,\n"
+ + " `c_decimal_unsigned_30` DECIMAL(30) unsigned
DEFAULT NULL,\n"
+ + " `c_decimal_30` DECIMAL(30)
DEFAULT NULL,\n"
Review Comment:
move to end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
