ic4y commented on code in PR #4936:
URL: https://github.com/apache/seatunnel/pull/4936#discussion_r1234656051
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/relational/connection/JdbcConnectionPoolFactory.java:
##########
@@ -39,6 +39,7 @@ public HikariDataSource
createPooledDataSource(JdbcSourceConfig sourceConfig) {
config.setJdbcUrl(sourceConfig.getOriginUrl());
config.setUsername(sourceConfig.getUsername());
config.setPassword(sourceConfig.getPassword());
+ config.setDriverClassName(sourceConfig.getDriverClassName());
Review Comment:
The addition of this might cause a driver load deadlock through the
Class.forName method.
https://github.com/apache/seatunnel/pull/4878/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
