davidzollo commented on code in PR #5005:
URL: https://github.com/apache/seatunnel/pull/5005#discussion_r1249465296
##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/ElasticsearchRowSerializer.java:
##########
@@ -81,7 +84,7 @@ public String serializeRow(SeaTunnelRow row) {
private String serializeUpsert(SeaTunnelRow row) {
String key = keyExtractor.apply(row);
- Map<String, Object> document = toDocumentMap(row);
+ String document = new String(serializationSchema.serialize(row));
Review Comment:
I'm confused about the usage, why use new String? I see that `String
serialize(SeaTunnelRow row);` return String
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
