happyboy1024 commented on PR #5011: URL: https://github.com/apache/seatunnel/pull/5011#issuecomment-1627708377
> > > fix it like this #5037 > > > > > > yes, #5037 fixed the connections leak, but I think we need to unregister this listener after the backfillReadTask is finished. Because the binlogClient is reuse and its internal listener are a list, subsequent binlog records trigger these listener and add data to the queue, causing memory to grow and GC to be triggered frequently. Do you think there is such a problem here? > > Agree with you, but copy `MySqlStreamingChangeEventSource` is difficult to maintain > > Can it be modified like this? > > <img alt="image" width="1174" src="https://user-images.githubusercontent.com/14371345/252125188-1fd0df74-14a8-49ae-9897-ac10f0ec14da.png";> It looks better this way. I did not consider using reflection to solve this problem, I will test it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/14371345/252125188-1fd0df74-14a8-49ae-9897-ac10f0ec14da.png"](https://user-images.githubusercontent.com/14371345/252125188-1fd0df74-14a8-49ae-9897-ac10f0ec14da.png"){kind=link}