Hisoka-X commented on code in PR #4989:
URL: https://github.com/apache/seatunnel/pull/4989#discussion_r1257690560
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialectFactory.java:
##########
@@ -37,4 +37,14 @@ public interface JdbcDialectFactory {
/** @return Creates a new instance of the {@link JdbcDialect}. */
JdbcDialect create();
+
+ /**
+ * Create a {@link JdbcDialect} instance based on the driver type.
Review Comment:
```suggestion
* Create a {@link JdbcDialect} instance based on the driver type and
compatible mode.
```
##########
docs/en/connector-v2/sink/OceanBase.md:
##########
@@ -0,0 +1,186 @@
+# OceanBase
+
+> JDBC OceanBase Sink Connector
+
+## Support Those Engines
+
+> Spark<br/>
+> Flink<br/>
+> Seatunnel Zeta<br/>
Review Comment:
```suggestion
> SeaTunnel Zeta<br/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
