liugddx commented on code in PR #5072:
URL: https://github.com/apache/seatunnel/pull/5072#discussion_r1263242679
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/DataConverter.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.data;
+
+import org.apache.iceberg.data.Record;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+
+/**
+ *
+ *
+ * @author mustard
+ * @version 1.0
+ * Create by 2023-07-05
+ */
Review Comment:
The same above
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/config/SinkConfig.java:
##########
@@ -0,0 +1,48 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.config;
+
+import lombok.Getter;
+import lombok.ToString;
+import org.apache.seatunnel.api.configuration.Option;
+import org.apache.seatunnel.api.configuration.Options;
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+
+/**
+ *
+ *
+ * @author mustard
+ * @version 1.0
+ * Create by 2023-07-05
+ */
Review Comment:
Remove these.
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/DefaultDataConverter.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.data;
Review Comment:
The same above
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/DefaultDataConverter.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.data;
+
+import lombok.NonNull;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.data.GenericRecord;
+import org.apache.iceberg.data.Record;
+import org.apache.iceberg.types.Type;
+import org.apache.iceberg.types.Types;
+import org.apache.seatunnel.api.table.type.*;
+import org.apache.seatunnel.common.exception.CommonErrorCode;
+import
org.apache.seatunnel.connectors.seatunnel.iceberg.exception.IcebergConnectorException;
+
+import java.math.BigDecimal;
+import java.nio.ByteBuffer;
+import java.time.*;
+import java.util.*;
+
+import static org.apache.iceberg.types.Type.TypeID.*;
+
+/**
+ *
+ *
+ * @author mustard
+ * @version 1.0
+ * Create by 2023-07-05
+ */
Review Comment:
The same above
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/DefaultDataConverter.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.data;
+
+import lombok.NonNull;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.data.GenericRecord;
+import org.apache.iceberg.data.Record;
+import org.apache.iceberg.types.Type;
+import org.apache.iceberg.types.Types;
+import org.apache.seatunnel.api.table.type.*;
+import org.apache.seatunnel.common.exception.CommonErrorCode;
+import
org.apache.seatunnel.connectors.seatunnel.iceberg.exception.IcebergConnectorException;
+
+import java.math.BigDecimal;
+import java.nio.ByteBuffer;
+import java.time.*;
+import java.util.*;
+
+import static org.apache.iceberg.types.Type.TypeID.*;
+
+/**
+ *
+ *
+ * @author mustard
+ * @version 1.0
+ * Create by 2023-07-05
+ */
+@RequiredArgsConstructor
Review Comment:
The same above
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/sink/IcebergSink.java:
##########
@@ -0,0 +1,118 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.sink;
+
+import com.google.auto.service.AutoService;
+import lombok.SneakyThrows;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.types.Types;
+import org.apache.seatunnel.api.common.PrepareFailException;
+import org.apache.seatunnel.api.sink.SeaTunnelSink;
+import org.apache.seatunnel.api.sink.SinkWriter;
+import org.apache.seatunnel.api.table.catalog.CatalogTableUtil;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.common.config.CheckConfigUtil;
+import org.apache.seatunnel.common.config.CheckResult;
+import
org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSimpleSink;
+import
org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSinkWriter;
+import org.apache.seatunnel.connectors.seatunnel.iceberg.IcebergTableLoader;
+import org.apache.seatunnel.connectors.seatunnel.iceberg.config.CommonConfig;
+import org.apache.seatunnel.connectors.seatunnel.iceberg.config.SinkConfig;
+import
org.apache.seatunnel.connectors.seatunnel.iceberg.data.IcebergTypeMapper;
+import
org.apache.seatunnel.connectors.seatunnel.iceberg.sink.writer.IcebergSinkWriter;
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import static com.google.common.base.Preconditions.checkArgument;
+
+/**
+ *
+ *
+ * @author mustard
+ * @version 1.0
+ * Create by 2023-07-05
+ */
Review Comment:
The same above
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/sink/IcebergSinkFactory.java:
##########
@@ -0,0 +1,46 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.sink;
+
+import com.google.auto.service.AutoService;
+import org.apache.seatunnel.api.configuration.util.OptionRule;
+import org.apache.seatunnel.api.table.connector.TableSink;
+import org.apache.seatunnel.api.table.factory.Factory;
+import org.apache.seatunnel.api.table.factory.TableFactoryContext;
+import org.apache.seatunnel.api.table.factory.TableSinkFactory;
+import org.apache.seatunnel.connectors.seatunnel.iceberg.config.SinkConfig;
+
+/**
+ *
+ *
+ * @author mustard
+ * @version 1.0
+ * Create by 2023-07-05
+ */
Review Comment:
The same above
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/DataConverter.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.seatunnel.connectors.seatunnel.iceberg.data;
+
+import org.apache.iceberg.data.Record;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+
+/**
+ *
+ *
+ * @author mustard
+ * @version 1.0
+ * Create by 2023-07-05
+ */
+public interface DataConverter {
Review Comment:
The same above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
