Hisoka-X commented on code in PR #5089:
URL: https://github.com/apache/seatunnel/pull/5089#discussion_r1264299271
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java:
##########
@@ -144,4 +144,10 @@ public interface JdbcOptions {
.intType()
.noDefaultValue()
.withDescription("partition num");
+
+ Option<String> FIELD_IDE =
+ Options.key("field_ide")
+ .stringType()
Review Comment:
We support enum type, please use it.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/psql/PostgresDialect.java:
##########
@@ -88,4 +97,32 @@ public PreparedStatement creatPreparedStatement(
}
return statement;
}
+
+ @Override
+ public String tableIdentifier(String database, String tableName) {
+ // resolve pg database name upper or lower not recognised
+ return quoteDatabaseIdentifier(database) + "." +
quoteIdentifier(tableName);
+ }
+
+ @Override
+ public String quoteIdentifier(String identifier) {
Review Comment:
Please add test case for this new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
