Hisoka-X commented on code in PR #4494:
URL: https://github.com/apache/seatunnel/pull/4494#discussion_r1270312737
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceReader.java:
##########
@@ -150,8 +160,27 @@ public void pollNext(Collector<SeaTunnelRow> output)
throws Exception {
recordList) {
try {
-
deserializationSchema.deserialize(
-
record.value(), output);
+ if
(StringUtils.isBlank(rowDelimiter)) {
Review Comment:
If the message in json contains `row_delimiter` value like `\n`:
```json
{"key":"value",
"key2":"value2"
}
```
The split will produce two wrong message which can't convert to normal json
string.
So I believe the feature only work normally when format are `text`.
Why not put this feature into `TextDeserializationSchema`? So that other
connector can get this feature too. cc @TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
