Hisoka-X commented on code in PR #5097:
URL: https://github.com/apache/seatunnel/pull/5097#discussion_r1271667467
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java:
##########
@@ -93,6 +98,19 @@ public String getPluginName() {
@Override
public void prepare(Config pluginConfig) throws PrepareFailException {
+ CheckResult checkResult =
Review Comment:
This is a little weird. We use ReadonlyConfig for now, if some required
config not be setted, we should use
```java
ConfigValidator.of(config).validate(new JdbcSourceFactory().optionRule());
```
to check it.
Also this is a temporary solution. cc @hailin0 @EricJoy2048 @TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
