hailin0 commented on PR #5045: URL: https://github.com/apache/seatunnel/pull/5045#issuecomment-1647324761
> > > I think keep the Top-level interface definition is a good choice. > > > > > > @TyrantLucifer I want to explicitly emphasize this feature at the top level interface > > Otherwise, the internal implementation may be modified by someone at any time to lose this feature > > IMO, Emphasize certain rules that do not necessarily need to be reflected in the code definition. Annotations can be written to provide developers with hints. The design principles of the code should not be broken by actual business rules. With the current review quality, interface restrictions are less likely to be broken, mainly because interface restrictions currently have no side effects -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
