hailin0 commented on code in PR #5154:
URL: https://github.com/apache/seatunnel/pull/5154#discussion_r1288226112
##########
seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/source/HiveSourceFactory.java:
##########
@@ -37,6 +37,8 @@ public OptionRule optionRule() {
return OptionRule.builder()
.required(HiveConfig.TABLE_NAME)
.required(HiveConfig.METASTORE_URI)
+ .optional(HiveConfig.READ_PARTITIONS)
+ .optional(HiveConfig.READ_COLUMNS)
Review Comment:
Where are options used?
Use
[BaseSourceConfig.READ_PARTITIONS](https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/source/HiveSource.java#L102)
in the logic of the code, please check that the logic definition is consistent
with the physical execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
