TyrantLucifer commented on code in PR #5234:
URL: https://github.com/apache/seatunnel/pull/5234#discussion_r1288411807
##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/sink/HbaseSinkWriter.java:
##########
@@ -128,8 +129,13 @@ private Put convertRowToPut(SeaTunnelRow row) {
.collect(Collectors.toList());
for (Integer writeColumnIndex : writeColumnIndexes) {
String fieldName = seaTunnelRowType.getFieldName(writeColumnIndex);
- String familyName =
- hbaseParameters.getFamilyNames().getOrDefault(fieldName,
defaultFamilyName);
+ // This is the family of columns that we define to be written
through the.conf file
+ Map<String, String> configurationFamilyNames =
hbaseParameters.getFamilyNames();
+ String familyName =
configurationFamilyNames.getOrDefault(fieldName, defaultFamilyName);
+ if (!configurationFamilyNames.containsKey(ALL_COLUMNS)
Review Comment:
I have one question: Why you change the logic of this and what's the meaning
of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
