EricJoy2048 commented on code in PR #5129:
URL: https://github.com/apache/seatunnel/pull/5129#discussion_r1289579885


##########
docs/en/connector-v2/source/MyHours.md:
##########
@@ -131,13 +165,7 @@ connector will generate data as the following:
 |----------------------------------------------------------|
 | {"code":  200, "data":  "get success", "success":  true} |
 
-### schema [Config]
-
-#### fields [Config]
-
-the schema fields of upstream data
-
-### content_json [String]
+### content_json

Review Comment:
   Can you use real data obtained from MyHours as an example to illustrate?



##########
docs/en/connector-v2/source/MyHours.md:
##########
@@ -212,14 +240,14 @@ Here is an example:
 - Test data can be found at this link 
[mockserver-config.json](../../../../seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/resources/mockserver-config.json)
 - See this link for task configuration 
[http_contentjson_to_assert.conf](../../../../seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/resources/http_contentjson_to_assert.conf).
 
-### json_field [Config]
+### json_field

Review Comment:
   Same as above.



##########
docs/en/connector-v2/source/MyHours.md:
##########
@@ -131,13 +165,7 @@ connector will generate data as the following:
 |----------------------------------------------------------|
 | {"code":  200, "data":  "get success", "success":  true} |
 
-### schema [Config]
-
-#### fields [Config]
-
-the schema fields of upstream data
-
-### content_json [String]
+### content_json

Review Comment:
   Can you use real data obtained from MyHours as an example to illustrate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to