ic4y commented on PR #5263: URL: https://github.com/apache/seatunnel/pull/5263#issuecomment-1674154337
> hi, why are these two parameters removed? Is there no need to exist, or are there other better solutions? At present, the engine internally only supports situations with `max-concurrent=1` and `tolerable-failure=0`. Therefore, these two parameters are meaningless. Removing them will make the code clearer and less prone to errors. Moreover, I believe there is no need for concurrent checkpointing in the synchronous engine scenario. Without concurrent checkpoints, `tolerable-failure` can only be set to 0; otherwise, it may lead to data inconsistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
