Hisoka-X commented on code in PR #5328:
URL: https://github.com/apache/seatunnel/pull/5328#discussion_r1303874087
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oracle/OracleCreateTableSqlBuilder.java:
##########
@@ -138,31 +147,40 @@ private String buildColumnType(Column column) {
}
}
- private String buildPrimaryKeySql(PrimaryKey primaryKey) {
+ private String buildPrimaryKeySql(PrimaryKey primaryKey, String fieldIde) {
String randomSuffix = UUID.randomUUID().toString().replace("-",
"").substring(0, 4);
- String columnNamesString = String.join(", ",
primaryKey.getColumnNames());
+ // String columnNamesString = String.join(", ",
primaryKey.getColumnNames());
Review Comment:
```suggestion
```
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dialectenum/FieldIdeEnum.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.dialectenum;
+
+public enum FieldIdeEnum {
Review Comment:
I'm a litttle curious, where did you get the name: `FieldIde`？ Because it
just `LetterCase `
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/psql/PostgresCreateTableSqlBuilder.java:
##########
@@ -46,14 +47,23 @@ public PostgresCreateTableSqlBuilder(CatalogTable
catalogTable) {
}
public String build(TablePath tablePath) {
+ return build(tablePath, "");
+ }
+
+ public String build(TablePath tablePath, String fieldIde) {
Review Comment:
Put `fieldIde` as `PostgresCreateTableSqlBuilder` field, so you don't need
it as parameter for much methods.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dialectenum/FieldIdeEnum.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.dialectenum;
+
+public enum FieldIdeEnum {
Review Comment:
I'm a litttle curious, where did you get the name: `FieldIde`？ Because it
just `LetterCase `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
