[GitHub] [seatunnel] Hisoka-X commented on pull request #5265: [Feature] [seatunnel-engine-core] Support loading remote third-party jars

Sat, 26 Aug 2023 03:39:16 -0700 


Hisoka-X commented on PR #5265:
URL: https://github.com/apache/seatunnel/pull/5265#issuecomment-1694254156

   > 在企业项目中可以使用，因为这需要一个远程的jar包,所以需要一个远程地址的目录存储的有这个jar包, 我不知道这样可否通过测试
   > […](#)
   > ------------------ 原始邮件 ------------------ 发件人: 
"apache/seatunnel" ***@***.***>; 发送时间: 2023年8月26日(星期六) 晚上6:25 
***@***.***>; ***@***.******@***.***>; 主题: Re: [apache/seatunnel] 
[Feature] [seatunnel-engine-core] Support loading remote third-party jars (PR 
#5265) @Hisoka-X commented on this pull request. Could you add test case for 
this feature? Thanks. Because just review the code, I'm not sure it will work 
fine. In 
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java: 
&gt; @@ -162,6 +166,21 @@ public static Set<Path&gt; getThirdPartyJars(String 
paths) { .collect(Collectors.toSet()); } + public static Set<URL&gt; 
getThirdPartyJarsURL(String paths) { + return Arrays.stream(paths.split(";")) + 
.filter(s -&gt; !"".equals(s)) maybe use StringUtils.isNotBlank will be better. 
— Reply to this email directly, view it on GitHub, or unsubscribe. You are 
receiving this because you authored the t
 hread.Message ID: ***@***.***&gt;
   
   Just use http path like 
`https://repo1.maven.org/maven2/org/apache/seatunnel/connector-console/2.3.3/connector-console-2.3.3.jar`?
 Is that can work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to