hailin0 commented on code in PR #5404:
URL: https://github.com/apache/seatunnel/pull/5404#discussion_r1311018879


##########
docs/en/connector-v2/sink/IoTDB.md:
##########
@@ -68,77 +68,46 @@ There is a conflict of thrift version between IoTDB and 
Spark.Therefore, you nee
 | connection_timeout_in_ms    | Integer | No       | -                         
     | The maximum time (in ms) to wait when connecting to `IoTDB`              
                                                                                
         |
 | common-options              |         | no       | -                         
     | Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details                                         
                      |
 
-## Task Example
-
-### Case1
-
-Common options:
+## Examples
 
 ```hocon
-sink {
-  IoTDB {
-    node_urls = ["localhost:6667"]
-    username = "root"
-    password = "root"
-    batch_size = 1024
-  }
+env {
+  execution.parallelism = 2
+  job.mode = "BATCH"
 }
-```
 
-When you assign `key_device`  is `device_name`, for example:
-
-```hocon
-sink {
-  IoTDB {
-    ...
-    key_device = "device_name"
+source {
+  FakeSource {
+    row.num = 16
+    schema = {
+      fields {
+        device_name = "string"
+        temperature = "float"
+        moisture = "bigint"
+      }
+    }
   }
 }
-```
 
-Upstream SeaTunnelRow data format is the following:

Review Comment:
   why delete?



##########
docs/en/connector-v2/sink/IoTDB.md:
##########
@@ -68,77 +68,46 @@ There is a conflict of thrift version between IoTDB and 
Spark.Therefore, you nee
 | connection_timeout_in_ms    | Integer | No       | -                         
     | The maximum time (in ms) to wait when connecting to `IoTDB`              
                                                                                
         |
 | common-options              |         | no       | -                         
     | Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details                                         
                      |
 
-## Task Example
-
-### Case1
-
-Common options:
+## Examples
 
 ```hocon
-sink {
-  IoTDB {
-    node_urls = ["localhost:6667"]
-    username = "root"
-    password = "root"
-    batch_size = 1024
-  }
+env {
+  execution.parallelism = 2
+  job.mode = "BATCH"
 }
-```
 
-When you assign `key_device`  is `device_name`, for example:
-
-```hocon
-sink {
-  IoTDB {
-    ...
-    key_device = "device_name"
+source {
+  FakeSource {
+    row.num = 16
+    schema = {
+      fields {
+        device_name = "string"
+        temperature = "float"
+        moisture = "bigint"
+      }
+    }
   }
 }
-```
 
-Upstream SeaTunnelRow data format is the following:
-
-|       device_name        | field_1 | field_2 |
-|--------------------------|---------|---------|
-| root.test_group.device_a | 1001    | 1002    |
-| root.test_group.device_b | 2001    | 2002    |
-| root.test_group.device_c | 3001    | 3002    |
-
-Output to `IoTDB` data format is the following:
-
-```shell
-IoTDB> SELECT * FROM root.test_group.* align by device;
-+------------------------+------------------------+-----------+----------+
-|                    Time|                  Device|   field_1|    field_2|
-+------------------------+------------------------+----------+-----------+
-|2022-09-26T17:50:01.201Z|root.test_group.device_a|      1001|       1002|
-|2022-09-26T17:50:01.202Z|root.test_group.device_b|      2001|       2002|
-|2022-09-26T17:50:01.203Z|root.test_group.device_c|      3001|       3002|
-+------------------------+------------------------+----------+-----------+
-```
-
-### Case2
-
-When you assign `key_device`、`key_timestamp`、`key_measurement_fields`, for 
example:
-
-```hocon
 sink {
   IoTDB {
-    ...
+    node_urls = "localhost:6667"
+    username = "root"
+    password = "root"
     key_device = "device_name"
-    key_timestamp = "ts"
     key_measurement_fields = ["temperature", "moisture"]
   }
 }
+
 ```
 
 Upstream SeaTunnelRow data format is the following:
 
-|      ts       |       device_name        | field_1 | field_2 | temperature | 
moisture |

Review Comment:
   whl update ?



##########
docs/en/connector-v2/sink/IoTDB.md:
##########
@@ -68,77 +68,46 @@ There is a conflict of thrift version between IoTDB and 
Spark.Therefore, you nee
 | connection_timeout_in_ms    | Integer | No       | -                         
     | The maximum time (in ms) to wait when connecting to `IoTDB`              
                                                                                
         |
 | common-options              |         | no       | -                         
     | Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details                                         
                      |
 
-## Task Example
-
-### Case1
-
-Common options:
+## Examples
 
 ```hocon
-sink {
-  IoTDB {
-    node_urls = ["localhost:6667"]
-    username = "root"
-    password = "root"
-    batch_size = 1024
-  }
+env {
+  execution.parallelism = 2
+  job.mode = "BATCH"
 }
-```
 
-When you assign `key_device`  is `device_name`, for example:
-
-```hocon
-sink {
-  IoTDB {
-    ...
-    key_device = "device_name"
+source {
+  FakeSource {
+    row.num = 16
+    schema = {
+      fields {
+        device_name = "string"
+        temperature = "float"
+        moisture = "bigint"
+      }
+    }
   }
 }
-```
 
-Upstream SeaTunnelRow data format is the following:
-
-|       device_name        | field_1 | field_2 |
-|--------------------------|---------|---------|
-| root.test_group.device_a | 1001    | 1002    |
-| root.test_group.device_b | 2001    | 2002    |
-| root.test_group.device_c | 3001    | 3002    |
-
-Output to `IoTDB` data format is the following:
-
-```shell
-IoTDB> SELECT * FROM root.test_group.* align by device;
-+------------------------+------------------------+-----------+----------+
-|                    Time|                  Device|   field_1|    field_2|
-+------------------------+------------------------+----------+-----------+
-|2022-09-26T17:50:01.201Z|root.test_group.device_a|      1001|       1002|
-|2022-09-26T17:50:01.202Z|root.test_group.device_b|      2001|       2002|
-|2022-09-26T17:50:01.203Z|root.test_group.device_c|      3001|       3002|
-+------------------------+------------------------+----------+-----------+
-```
-
-### Case2
-
-When you assign `key_device`、`key_timestamp`、`key_measurement_fields`, for 
example:
-
-```hocon
 sink {
   IoTDB {
-    ...
+    node_urls = "localhost:6667"
+    username = "root"
+    password = "root"
     key_device = "device_name"
-    key_timestamp = "ts"

Review Comment:
   why delete?



##########
docs/en/connector-v2/sink/IoTDB.md:
##########
@@ -68,77 +68,46 @@ There is a conflict of thrift version between IoTDB and 
Spark.Therefore, you nee
 | connection_timeout_in_ms    | Integer | No       | -                         
     | The maximum time (in ms) to wait when connecting to `IoTDB`              
                                                                                
         |
 | common-options              |         | no       | -                         
     | Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details                                         
                      |
 
-## Task Example
-
-### Case1
-
-Common options:
+## Examples
 
 ```hocon
-sink {
-  IoTDB {
-    node_urls = ["localhost:6667"]
-    username = "root"
-    password = "root"
-    batch_size = 1024
-  }
+env {
+  execution.parallelism = 2
+  job.mode = "BATCH"
 }
-```
 
-When you assign `key_device`  is `device_name`, for example:
-
-```hocon
-sink {
-  IoTDB {
-    ...
-    key_device = "device_name"
+source {
+  FakeSource {
+    row.num = 16
+    schema = {
+      fields {
+        device_name = "string"
+        temperature = "float"
+        moisture = "bigint"
+      }
+    }
   }
 }
-```
 
-Upstream SeaTunnelRow data format is the following:
-
-|       device_name        | field_1 | field_2 |
-|--------------------------|---------|---------|
-| root.test_group.device_a | 1001    | 1002    |
-| root.test_group.device_b | 2001    | 2002    |
-| root.test_group.device_c | 3001    | 3002    |
-
-Output to `IoTDB` data format is the following:
-
-```shell
-IoTDB> SELECT * FROM root.test_group.* align by device;
-+------------------------+------------------------+-----------+----------+
-|                    Time|                  Device|   field_1|    field_2|
-+------------------------+------------------------+----------+-----------+
-|2022-09-26T17:50:01.201Z|root.test_group.device_a|      1001|       1002|
-|2022-09-26T17:50:01.202Z|root.test_group.device_b|      2001|       2002|
-|2022-09-26T17:50:01.203Z|root.test_group.device_c|      3001|       3002|
-+------------------------+------------------------+----------+-----------+
-```
-
-### Case2
-
-When you assign `key_device`、`key_timestamp`、`key_measurement_fields`, for 
example:
-
-```hocon
 sink {
   IoTDB {
-    ...
+    node_urls = "localhost:6667"
+    username = "root"
+    password = "root"
     key_device = "device_name"
-    key_timestamp = "ts"
     key_measurement_fields = ["temperature", "moisture"]
   }
 }
+
 ```
 
 Upstream SeaTunnelRow data format is the following:
 
-|      ts       |       device_name        | field_1 | field_2 | temperature | 
moisture |

Review Comment:
   whl update ?



##########
docs/en/connector-v2/sink/IoTDB.md:
##########
@@ -68,77 +68,46 @@ There is a conflict of thrift version between IoTDB and 
Spark.Therefore, you nee
 | connection_timeout_in_ms    | Integer | No       | -                         
     | The maximum time (in ms) to wait when connecting to `IoTDB`              
                                                                                
         |
 | common-options              |         | no       | -                         
     | Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details                                         
                      |
 
-## Task Example
-
-### Case1
-
-Common options:
+## Examples
 
 ```hocon
-sink {
-  IoTDB {
-    node_urls = ["localhost:6667"]
-    username = "root"
-    password = "root"
-    batch_size = 1024
-  }
+env {
+  execution.parallelism = 2
+  job.mode = "BATCH"
 }
-```
 
-When you assign `key_device`  is `device_name`, for example:
-
-```hocon
-sink {
-  IoTDB {
-    ...
-    key_device = "device_name"
+source {
+  FakeSource {
+    row.num = 16
+    schema = {
+      fields {
+        device_name = "string"
+        temperature = "float"
+        moisture = "bigint"
+      }
+    }
   }
 }
-```
 
-Upstream SeaTunnelRow data format is the following:
-
-|       device_name        | field_1 | field_2 |
-|--------------------------|---------|---------|
-| root.test_group.device_a | 1001    | 1002    |
-| root.test_group.device_b | 2001    | 2002    |
-| root.test_group.device_c | 3001    | 3002    |
-
-Output to `IoTDB` data format is the following:
-
-```shell
-IoTDB> SELECT * FROM root.test_group.* align by device;
-+------------------------+------------------------+-----------+----------+
-|                    Time|                  Device|   field_1|    field_2|
-+------------------------+------------------------+----------+-----------+
-|2022-09-26T17:50:01.201Z|root.test_group.device_a|      1001|       1002|
-|2022-09-26T17:50:01.202Z|root.test_group.device_b|      2001|       2002|
-|2022-09-26T17:50:01.203Z|root.test_group.device_c|      3001|       3002|
-+------------------------+------------------------+----------+-----------+
-```
-
-### Case2
-
-When you assign `key_device`、`key_timestamp`、`key_measurement_fields`, for 
example:
-
-```hocon
 sink {
   IoTDB {
-    ...
+    node_urls = "localhost:6667"
+    username = "root"
+    password = "root"
     key_device = "device_name"
-    key_timestamp = "ts"

Review Comment:
   why delete?



##########
docs/en/connector-v2/sink/IoTDB.md:
##########
@@ -68,77 +68,46 @@ There is a conflict of thrift version between IoTDB and 
Spark.Therefore, you nee
 | connection_timeout_in_ms    | Integer | No       | -                         
     | The maximum time (in ms) to wait when connecting to `IoTDB`              
                                                                                
         |
 | common-options              |         | no       | -                         
     | Sink plugin common parameters, please refer to [Sink Common 
Options](common-options.md) for details                                         
                      |
 
-## Task Example
-
-### Case1
-
-Common options:
+## Examples
 
 ```hocon
-sink {
-  IoTDB {
-    node_urls = ["localhost:6667"]
-    username = "root"
-    password = "root"
-    batch_size = 1024
-  }
+env {
+  execution.parallelism = 2
+  job.mode = "BATCH"
 }
-```
 
-When you assign `key_device`  is `device_name`, for example:
-
-```hocon
-sink {
-  IoTDB {
-    ...
-    key_device = "device_name"
+source {
+  FakeSource {
+    row.num = 16
+    schema = {
+      fields {
+        device_name = "string"
+        temperature = "float"
+        moisture = "bigint"
+      }
+    }
   }
 }
-```
 
-Upstream SeaTunnelRow data format is the following:

Review Comment:
   why delete?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to