EricJoy2048 commented on code in PR #5361:
URL: https://github.com/apache/seatunnel/pull/5361#discussion_r1312732777
##########
docs/en/connector-v2/sink/RocketMQ.md:
##########
@@ -1,44 +1,43 @@
# RocketMQ
> RocketMQ sink connector
->
- ## Description
-Write Rows to a Apache RocketMQ topic.
-
-## Key features
-
-- [x] [exactly-once](../../concept/connector-v2-features.md)
+## Support Apache RocketMQ Version
-By default, we will use 2pc to guarantee the message is sent to RocketMQ
exactly once.
+- 4.9.0 (Or a newer version, for reference)
-## Options
+## Support These Engines
-| name | type | required | default value |
-|----------------------|---------|----------|--------------------------|
-| topic | string | yes | - |
-| name.srv.addr | string | yes | - |
-| acl.enabled | Boolean | no | false |
-| access.key | String | no | |
-| secret.key | String | no | |
-| producer.group | String | no | SeaTunnel-producer-Group |
-| semantic | string | no | NON |
-| partition.key.fields | array | no | - |
-| format | String | no | json |
-| field.delimiter | String | no | , |
-| common-options | config | no | - |
+> Spark<br/>
+> Flink<br/>
+> SeaTunnel Zeta<br/>
-### topic [string]
+## Key features
-`RocketMQ topic` name.
+- [x] [exactly-once](../../concept/connector-v2-features.md)
-### name.srv.addr [string]
+By default, we will use 2pc to guarantee the message is sent to RocketMQ
exactly once.
-`RocketMQ` name server cluster address.
+## Description
-### semantic [string]
+Write Rows to a Apache RocketMQ topic.
-Semantics that can be chosen EXACTLY_ONCE/AT_LEAST_ONCE/NON, default NON.
+## Sink Options
+
+| Name | Type | Required | Default |
Description
|
+|----------------------|---------|----------|--------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| topic | string | yes | - |
`RocketMQ topic` name.
|
+| name.srv.addr | string | yes | - |
`RocketMQ` name server cluster address.
|
+| acl.enabled | Boolean | no | false | false
|
+| access.key | String | no | | When
ACL_ENABLED is true, access key cannot be empty
|
+| secret.key | String | no | | When
ACL_ENABLED is true, secret key cannot be empty
|
+| producer.group | String | no | SeaTunnel-producer-Group |
SeaTunnel-producer-Group
|
+| semantic | string | no | NON |
Semantics that can be chosen EXACTLY_ONCE/AT_LEAST_ONCE/NON, default NON.
|
Review Comment:
Do you read the `RocketMqSinkFactory` code? Some options I don't found in
the code.
<img width="1227" alt="image"
src="https://github.com/apache/seatunnel/assets/32193458/e13f99f7-8ce8-4c9a-84c0-ddd94c771146";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
